Spec URL: http://devserv.devel/~dwalsh/SELinux/mcstrans.spec SRPM URL: http://devserv.devel/~dwalsh/SELinux/mcstrans-0.1.1-1.src.rpm Description: mcstrans is a replacement for libsetrans. Basically libselinux will not use a daemon for its translations instead of a shared library. This will allow us to easily swap in and out different translation daemons.
Bad: - buildroot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Source url is 404: http://fedora.redhat.com/projects/mcstrans-0.1.1.tgz - Build fails on both arches, probably a missing BuildRequires: mcstransd.c:16:29: error: selinux/setrans.h: No such file or directory Should be fixed: - Mix of variables like $RPM_BUILD_ROOT and %{optflags}. One method should be consistant throughout NEEDSWORK
Bad: - buildroot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) > Changed to this. - Source url is 404: http://fedora.redhat.com/projects/mcstrans-0.1.1.tgz > Not sure where this link should point. We are upstream for this so but I am not sure where we are supposed to put these tarballs. - Build fails on both arches, probably a missing BuildRequires: mcstransd.c:16:29: error: selinux/setrans.h: No such file or directory > Fixed Should be fixed: - Mix of variables like $RPM_BUILD_ROOT and %{optflags}. One method should be consistant throughout > Fixed I updated the tarball and spec file on http://devserv.devel/~dwalsh/SELinux
So it builds now, but rpmlint isn't completely happy. - Obsoletes libsetrans, but doesn't provide it. It should provide it for clean upgrade - Use of Prereq, this should actually be Requires(pre): followed by a Requires(post): (sorry I didn't notice this first) That should be it. A couple more Warnings but they can be ignored: W: mcstrans no-url-tag (already talked about, will get that later) W: mcstrans service-default-enabled /etc/init.d/mcstransd (we want this enabled) W: mcstrans incoherent-init-script-name mcstransd (um, whatever)
Updated again. We need this in tonight, since libselinux requires it in rawhide now...
Builds now, just the ignorable warnings. Approving. (and since you're asleep probably, building it for rawhide.)
Package was released to rawhide.