Bug 1911780

Summary: Review Request: R-gitcreds - Query 'git' Credentials from 'R'
Product: [Fedora] Fedora Reporter: Elliott Sales de Andrade <quantum.analyst>
Component: Package ReviewAssignee: José Matos <jamatos>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: jamatos, package-review
Target Milestone: ---Flags: jamatos: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: R-gitcreds-0.1.1-1.fc34 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-01-01 00:04:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1911783    
Bug Blocks: 1911777    

Description Elliott Sales de Andrade 2020-12-31 07:13:00 UTC 
Spec URL: https://qulogic.fedorapeople.org/reviews/R-gitcreds/R-gitcreds.spec
SRPM URL: https://qulogic.fedorapeople.org/reviews/R-gitcreds/R-gitcreds-0.1.1-1.fc33.src.rpm

Description:
Query, set, delete credentials from the git credential store. Manage
GitHub tokens and other git credentials. This package is to be used by
other packages that need to authenticate to GitHub and/or other git
repositories.
Comment 1 José Matos 2020-12-31 16:02:17 UTC 
The license is correct and appropriated for Fedora.
The spec file is simple and correct.

fedora-review complains:
- Package have the default element marked as %%doc :DESCRIPTION
- Package requires R-core.

The only pattern that I am seeing here is the number of 0.1.1 packages that are introduced in the updates of R packages. :-)

After reviewing so many packages the other thing that shows up is that probably the %install section could get a macro on R-rpm-macros since this chunk appears so many times:

mkdir -p %{buildroot}%{rlibdir}
%{_bindir}/R CMD INSTALL -l %{buildroot}%{rlibdir} %{packname}
test -d %{packname}/src && (cd %{packname}/src; rm -f *.o *.so)
rm -f %{buildroot}%{rlibdir}/R.css

The package is approved.
Comment 2 Elliott Sales de Andrade 2020-12-31 21:23:32 UTC 
Thank you for the review, José

https://pagure.io/releng/fedora-scm-requests/issue/31520
Comment 3 Gwyn Ciesla 2020-12-31 21:31:17 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/R-gitcreds