Spec URL: https://qulogic.fedorapeople.org/reviews/R-oskeyring/R-oskeyring.spec SRPM URL: https://qulogic.fedorapeople.org/reviews/R-oskeyring/R-oskeyring-0.1.1-1.fc33.src.rpm Description: Aims to support all features of the system credential store, including non- portable ones. Supports Keychain on macOS, and Credential Manager on Windows. See the keyring package if you need a portable API. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=58646875
The license is correct and appropriated for Fedora. The spec file is simple and correct. fedora-review complains: - Package have the default element marked as %%doc :DESCRIPTION - Package requires R-core. - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ The package is approved. This is a not a macro but someday I need to do one just like a rubber stamp, probably next year. :-)
Thanks! Can you set fedora-review+ then?
(In reply to Elliott Sales de Andrade from comment #2) > Thanks! Can you set fedora-review+ then? Oops my mistake, I thought I had set a + OK, last review of 2020. :-) Happy New Year for all.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-oskeyring
Thank you for the review, José https://pagure.io/releng/fedora-scm-requests/issue/31521
Happy New Year to you too!