Spec URL: https://qulogic.fedorapeople.org/reviews/R-gitcreds/R-gitcreds.spec SRPM URL: https://qulogic.fedorapeople.org/reviews/R-gitcreds/R-gitcreds-0.1.1-1.fc33.src.rpm Description: Query, set, delete credentials from the git credential store. Manage GitHub tokens and other git credentials. This package is to be used by other packages that need to authenticate to GitHub and/or other git repositories.
The license is correct and appropriated for Fedora. The spec file is simple and correct. fedora-review complains: - Package have the default element marked as %%doc :DESCRIPTION - Package requires R-core. The only pattern that I am seeing here is the number of 0.1.1 packages that are introduced in the updates of R packages. :-) After reviewing so many packages the other thing that shows up is that probably the %install section could get a macro on R-rpm-macros since this chunk appears so many times: mkdir -p %{buildroot}%{rlibdir} %{_bindir}/R CMD INSTALL -l %{buildroot}%{rlibdir} %{packname} test -d %{packname}/src && (cd %{packname}/src; rm -f *.o *.so) rm -f %{buildroot}%{rlibdir}/R.css The package is approved.
Thank you for the review, José https://pagure.io/releng/fedora-scm-requests/issue/31520
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-gitcreds