Bug 1911783

Summary:	Review Request: R-oskeyring - Raw System Credential Store Access from R
Product:	[Fedora] Fedora	Reporter:	Elliott Sales de Andrade <quantum.analyst>
Component:	Package Review	Assignee:	José Matos <jamatos>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jamatos, package-review
Target Milestone:	---	Flags:	jamatos: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	R-oskeyring-0.1.1-1.fc34	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-12-31 23:48:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1911780

Description Elliott Sales de Andrade 2020-12-31 07:19:52 UTC

Spec URL: https://qulogic.fedorapeople.org/reviews/R-oskeyring/R-oskeyring.spec
SRPM URL: https://qulogic.fedorapeople.org/reviews/R-oskeyring/R-oskeyring-0.1.1-1.fc33.src.rpm

Description:
Aims to support all features of the system credential store, including non-
portable ones. Supports Keychain on macOS, and Credential Manager on
Windows. See the keyring package if you need a portable API.


Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=58646875

Comment 1 José Matos 2020-12-31 15:50:24 UTC

The license is correct and appropriated for Fedora.
The spec file is simple and correct.

fedora-review complains:
- Package have the default element marked as %%doc :DESCRIPTION
- Package requires R-core.
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

The package is approved.

This is a not a macro but someday I need to do one just like a rubber stamp, probably next year. :-)

Comment 2 Elliott Sales de Andrade 2020-12-31 21:21:44 UTC

Thanks! Can you set fedora-review+ then?

Comment 3 José Matos 2020-12-31 22:42:09 UTC

(In reply to Elliott Sales de Andrade from comment #2)
> Thanks! Can you set fedora-review+ then?

Oops my mistake, I thought I had set a +

OK, last review of 2020. :-)
Happy New Year for all.

Comment 4 Gwyn Ciesla 2020-12-31 22:45:52 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/R-oskeyring

Comment 5 Elliott Sales de Andrade 2020-12-31 22:47:23 UTC

Thank you for the review, José

https://pagure.io/releng/fedora-scm-requests/issue/31521

Comment 6 Elliott Sales de Andrade 2020-12-31 23:48:03 UTC

Happy New Year to you too!