Bug 191534
Summary: | Review Request: pygobject2 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | John (J5) Palmieri <johnp> |
Component: | Package Review | Assignee: | David Cantrell <dcantrell> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, jkeck |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-06-06 20:06:17 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 188268 |
Description
John (J5) Palmieri
2006-05-12 19:27:24 UTC
*** Bug 192460 has been marked as a duplicate of this bug. *** Bad: - Buildroot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Description line should be 80chars max per line - rpmlint isn't happy w/ the build package: E: pygobject2 script-without-shellbang /usr/share/doc/pygobject2-2.10.1/examples/Makefile.in E: pygobject2 script-without-shellbang /usr/share/doc/pygobject2-2.10.1/examples/signal.py E: pygobject2 script-without-shellbang /usr/lib64/python2.4/site-packages/pygtk.pth E: pygobject2 script-without-shellbang /usr/share/doc/pygobject2-2.10.1/examples/Makefile E: pygobject2 script-without-shellbang /usr/share/doc/pygobject2-2.10.1/AUTHORS E: pygobject2 script-without-shellbang /usr/lib64/python2.4/site-packages/pygtk.py E: pygobject2 script-without-shellbang /usr/share/doc/pygobject2-2.10.1/README E: pygobject2 script-without-shellbang /usr/share/doc/pygobject2-2.10.1/NEWS E: pygobject2 script-without-shellbang /usr/share/doc/pygobject2-2.10.1/examples/properties.py E: pygobject2 script-without-shellbang /usr/share/doc/pygobject2-2.10.1/ChangeLog E: pygobject2 script-without-shellbang /usr/share/doc/pygobject2-2.10.1/examples/Makefile.am rpmlint -I script-without-shellbang script-without-shellbang : This executable text file does not contain a shebang, thus it cannot be properly executed. Often this is a sign of spurious executable bits for a non-script file, but can also be a case of a missing shebang. To fix this error, find out which case of the above it is, and either remove the executable bits or add the shebang. Perhaps the defattr is a bit overbearing? Question: - The dep in the -devel package could lead to -devel being out of sync w/ a release of the main package. Is this an issue? Suggestion: - No period in summary lines - Add a URL tag NEEDSWORK Fixed Spec URL: http://people.redhat.com/johnp/files/pygobject/pygobject2.spec SRPM URL: http://people.redhat.com/johnp/files/pygobject/pygobject2-2.10.1-2.src.rpm rpmlint happy. I'm happy. Package happy. (; Approved. j5, has this been built yet? yes, awhile ago. Closing |