Bug 191534 - Review Request: pygobject2
Summary: Review Request: pygobject2
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Cantrell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 192460 (view as bug list)
Depends On:
Blocks: FC-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-05-12 19:27 UTC by John (J5) Palmieri
Modified: 2013-03-13 04:50 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2006-06-06 20:06:17 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description John (J5) Palmieri 2006-05-12 19:27:24 UTC 
Spec URL: http://people.redhat.com/johnp/files/pygobject/pygobject2.spec
SRPM URL: http://people.redhat.com/johnp/files/pygobject/pygobject2-2.10.1-1.src.rpm
Description: pygobject2 is a split of the pygtk2 package.  New versions of pygtk2 need pygobject2 to build.
Comment 1 John (J5) Palmieri 2006-05-19 19:56:37 UTC 
*** Bug 192460 has been marked as a duplicate of this bug. ***
Comment 2 Jesse Keating 2006-05-19 20:16:37 UTC 
Bad:
- Buildroot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Description line should be 80chars max per line
- rpmlint isn't happy w/ the build package:
E: pygobject2 script-without-shellbang
/usr/share/doc/pygobject2-2.10.1/examples/Makefile.in
E: pygobject2 script-without-shellbang
/usr/share/doc/pygobject2-2.10.1/examples/signal.py
E: pygobject2 script-without-shellbang /usr/lib64/python2.4/site-packages/pygtk.pth
E: pygobject2 script-without-shellbang
/usr/share/doc/pygobject2-2.10.1/examples/Makefile
E: pygobject2 script-without-shellbang /usr/share/doc/pygobject2-2.10.1/AUTHORS
E: pygobject2 script-without-shellbang /usr/lib64/python2.4/site-packages/pygtk.py
E: pygobject2 script-without-shellbang /usr/share/doc/pygobject2-2.10.1/README
E: pygobject2 script-without-shellbang /usr/share/doc/pygobject2-2.10.1/NEWS
E: pygobject2 script-without-shellbang
/usr/share/doc/pygobject2-2.10.1/examples/properties.py
E: pygobject2 script-without-shellbang /usr/share/doc/pygobject2-2.10.1/ChangeLog
E: pygobject2 script-without-shellbang
/usr/share/doc/pygobject2-2.10.1/examples/Makefile.am

rpmlint -I script-without-shellbang
script-without-shellbang :
This executable text file does not contain a shebang, thus it cannot be
properly executed.  Often this is a sign of spurious executable bits for a
non-script file, but can also be a case of a missing shebang.  To fix this
error, find out which case of the above it is, and either remove the
executable bits or add the shebang.

Perhaps the defattr is a bit overbearing?

Question:
- The dep in the -devel package could lead to -devel being out of sync w/ a
release of the main package.  Is this an issue?

Suggestion:
- No period in summary lines
- Add a URL tag

NEEDSWORK
Comment 3 John (J5) Palmieri 2006-05-19 21:51:13 UTC 
Fixed

Spec URL: http://people.redhat.com/johnp/files/pygobject/pygobject2.spec
SRPM URL: http://people.redhat.com/johnp/files/pygobject/pygobject2-2.10.1-2.src.rpm
Comment 4 Jesse Keating 2006-05-19 22:19:33 UTC 
rpmlint happy.  I'm happy.  Package happy.  (;

Approved.
Comment 5 Jesse Keating 2006-06-06 19:08:10 UTC 
j5, has this been built yet?
Comment 6 John (J5) Palmieri 2006-06-06 20:06:17 UTC 
yes, awhile ago. Closing
Note You need to log in before you can comment on or make changes to this bug.