Bug 191622
| Summary: | Review Request: perl-Expect - Expect for Perl | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jose Pedro Oliveira <jose.p.oliveira.oss> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | tremble |
| Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-05-17 16:51:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779, 191623 | ||
|
Description
Jose Pedro Oliveira
2006-05-13 23:27:49 UTC
That description is really suboptimal. How about something like this, partially stolen from the original Expect description: This module provides Expect-like functionality to Perl. Expect is a tool for automating interactive applications such as telnet, ftp, passwd, fsck, rlogin, tip, etc. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * license field matches the actual license. * license is open source-compatible. It's not included separately in the package, but this is not necessary as the upstream tarball does not include it. * source files match upstream: f5f0ea179c6f19d9f08e22c6a0072292 Expect-1.16.tar.gz f5f0ea179c6f19d9f08e22c6a0072292 Expect-1.16.tar.gz-srpm * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane. * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass: Passed 36 of 36 tests. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED, but please fix the description before checking in. (In reply to comment #1) > That description is really suboptimal. How about something like this, partially > stolen from the original Expect description: > > This module provides Expect-like functionality to Perl. Expect is a tool for > automating interactive applications such as telnet, ftp, passwd, fsck, rlogin, > tip, etc. Done. Importing the new SRPM (updated specfile in same location) http://gsd.di.uminho.pt/jpo/software/fedora/perl-Expect-1.16-2.src.rpm Thanks for the review. Imported and built for FC-5 and devel. Package Change Request ====================== Package Name: perl-Expect New Branches: EL-5 Owners: tremble From IRC: 16:06 < tremble> cweyl: Any chance of perl-Expect for EPEL ? 16:07 < cweyl> tremble: probably not from me :) If you want to branch and own the EPEL bits, I'm ok with that cvs done. |