Bug 191624
| Summary: | Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jose Pedro Oliveira <jose.p.oliveira.oss> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | tremble |
| Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-05-18 21:51:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 191623 | ||
| Bug Blocks: | 163779 | ||
|
Description
Jose Pedro Oliveira
2006-05-13 23:31:01 UTC
Module::Build is still having trouble in development; I'll review this on FC5. (We really should try to help Steve with that.) * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * license field matches the actual license. * license is open source-compatible. It's not included separately in the package, but this is not necessary as the upstream tarball does not include it. * source files match upstream: b22cb4575d910bb2d36e506a958da300 Test-Expect-0.30.tar.gz b22cb4575d910bb2d36e506a958da300 Test-Expect-0.30.tar.gz-srpm * latest version is being packaged. * BuildRequires are proper. * package builds in mock (FC5, x86_64), with perl-Expect and perl-Expect-Simple added. * rpmlint is silent. * final provides and requires are sane. * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass: All tests successful. Files=1, Tests=18, 0 wallclock secs ( 0.08 cusr + 0.04 csys = 0.12 CPU) * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED, but note that you won't be able to build on the development branch until the Module::Build problem gets worked out. (In reply to comment #1) > Module::Build is still having trouble in development; I'll review this on FC5. > (We really should try to help Steve with that.) Last saturday I started looking into it but gave up after one hour or so - I also wasn't able to see why perl(YAML) < 0.49 is being required. I will try again later in the day and/or tomorrow. Thanks for the review. Imported and built for FC-5 and devel. https://bugzilla.redhat.com/show_bug.cgi?id=191622 - cweyl implied he's not interested in EPEL, and at todays EPEL meeting Smooge suggested I should just put the requests through. Package Change Request ====================== Package Name: perl-Expect New Branches: EL-6 Owners: tremble Did you mean perl-Test-Expect there? I did, yes, sorry Package Change Request ====================== Package Name: perl-Test-Expect New Branches: EL-6 Owners: tremble cvs done. |