Bug 191815
| Summary: | escreensaver Missing BuildRequires | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andreas Thienemann <andreas> | ||||||||||
| Component: | xscreensaver | Assignee: | Ray Strode [halfline] <rstrode> | ||||||||||
| Status: | CLOSED DUPLICATE | QA Contact: | |||||||||||
| Severity: | medium | Docs Contact: | |||||||||||
| Priority: | medium | ||||||||||||
| Version: | rawhide | CC: | bdpepple, jwz, mtasaka | ||||||||||
| Target Milestone: | --- | ||||||||||||
| Target Release: | --- | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | Linux | ||||||||||||
| Whiteboard: | |||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||
| Doc Text: | Story Points: | --- | |||||||||||
| Clone Of: | Environment: | ||||||||||||
| Last Closed: | 2006-05-17 23:01:25 UTC | Type: | --- | ||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||
| Documentation: | --- | CRM: | |||||||||||
| Verified Versions: | Category: | --- | |||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
| Embargoed: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Andreas Thienemann
2006-05-15 22:29:40 UTC
Created attachment 129130 [details]
Patch, adding the missing buildreqs
I think that the comment 1 is not enough. I commented on this problem to Bug 191769. Well, the Package builds fine with only libjpeg, libXt and libXmu development packages installed. But you were partly right: libXxf86vm-devel is needed, but most likely libXxf86misc-devel is not. Some of the packaged screensavers are linking against libXxf86vm.so.1 but there's nothing needed from libXxf86misc-devel AFAIK. I checked that xscreensaver can be build without libXxf86misc-devel, that is true. However, libXxf86misc addes some extensional function to xscreensaver daemon. See driver/lock.c and HAVE_XF86MISCSETGRABKEYSSTATE (although I don't know what this is doing). Created attachment 129359 [details] rpmdiff error for previous BR patch. The previously attached BR patch doesn't contain all the necessary BR's. rpmdiff must be ran against the curent rawhide rpm to the ones you are building in mock to find *ALL* the BR needed. Refer to the wiki for more information, if you are not clear. http://fedoraproject.org/wiki/QA/FixBuildRequires Created attachment 129360 [details]
Correct BR patch
Created attachment 129361 [details]
Build log after corrected BR patch
|