Bug 1951479
Summary: | Review Request: perl-CLI-Osprey - MooX::Options + MooX::Cmd + Sanity | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Emmanuel Seyman <emmanuel> |
Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | jplesnik, package-review |
Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
emmanuel: needinfo+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | NotReady | ||
Fixed In Version: | perl-CLI-Osprey-0.08-1.fc35 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2021-06-04 08:34:56 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1951040 | ||
Bug Blocks: | 1950798 |
Description
Emmanuel Seyman
2021-04-20 08:56:36 UTC
Please add valid link for spec file. Spec URL: https://people.parinux.org/~seyman/fedora/perl-CLI-Osprey/perl-CLI-Osprey.spec SRPM URL: https://people.parinux.org/~seyman/fedora/perl-CLI-Osprey/perl-CLI-Osprey-0.08-1.fc33.src.rpm Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Please add build-require perl(lib) - t/load-on-use.t:5 TODO: Add version constrain to 'perl(Module::Build::Tiny) >= 0.034' $ rpm -qp --requires perl-CLI-Osprey-0.08-1.fc35.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 1 perl(CLI::Osprey::Descriptive) 1 perl(CLI::Osprey::Descriptive::Usage) 1 perl(CLI::Osprey::InlineSubcommand) 1 perl(Getopt::Long::Descriptive) >= 0.100 1 perl(Getopt::Long::Descriptive::Usage) 1 perl(:MODULE_COMPAT_5.32.1) 1 perl(Module::Runtime) 1 perl(Moo) 1 perl(Moo::Role) 1 perl(overload) 1 perl(Path::Tiny) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(warnings) Binary requires are almost Ok. FIX: Please add run-require perl(Pod::Usage) - lib/CLI/Osprey/Role.pm:321 $ rpm -qp --provides perl-CLI-Osprey-0.08-1.fc35.noarch.rpm | sort | uniq -c 1 perl(CLI::Osprey) = 0.08 1 perl-CLI-Osprey = 0.08-1.fc35 1 perl(CLI::Osprey::Descriptive) = 0.08 1 perl(CLI::Osprey::Descriptive::Usage) = 0.08 1 perl(CLI::Osprey::InlineSubcommand) = 0.08 1 perl(CLI::Osprey::Role) = 0.08 Binary provides are Ok. $ rpmlint ./perl-CLI-Osprey* perl-CLI-Osprey.noarch: W: spelling-error Summary(en_US) MooX -> Mo Ox, Moo X, Moon perl-CLI-Osprey.noarch: W: spelling-error Summary(en_US) Cmd -> Cm, Cd, Cmdr perl-CLI-Osprey.src: W: spelling-error Summary(en_US) MooX -> Mo Ox, Moo X, Moon perl-CLI-Osprey.src: W: spelling-error Summary(en_US) Cmd -> Cm, Cd, Cmdr 2 packages and 1 specfiles checked; 0 errors, 4 warnings. Rpmlint is ok Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items and consider fixing 'TODO' item. Resolution: Approved (In reply to Jitka Plesnikova from comment #3) > > FIX: Please add build-require > perl(lib) - t/load-on-use.t:5 Fixed. > TODO: Add version constrain to 'perl(Module::Build::Tiny) >= 0.034' Fixed. > FIX: Please add run-require > perl(Pod::Usage) - lib/CLI/Osprey/Role.pm:321 Fixed. Spec URL: https://people.parinux.org/~seyman/fedora/perl-CLI-Osprey/perl-CLI-Osprey.spec SRPM URL: https://people.parinux.org/~seyman/fedora/perl-CLI-Osprey/perl-CLI-Osprey-0.08-2.fc33.src.rpm > Resolution: > Approved Thank you, Jikta. I've requested the repository: https://pagure.io/releng/fedora-scm-requests/issue/33797 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-CLI-Osprey |