Bug 1951040 - Review Request: perl-Test-Lib - Use libraries from a t/lib directory
Summary: Review Request: perl-Test-Lib - Use libraries from a t/lib directory
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1951479
TreeView+ depends on / blocked
 
Reported: 2021-04-19 13:08 UTC by Emmanuel Seyman
Modified: 2021-04-29 07:17 UTC (History)
2 users (show)

Fixed In Version: perl-Test-Lib-0.002-1.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-04-29 07:17:19 UTC
Type: ---
Embargoed:
ppisar: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2021-04-19 13:08:21 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-Lib/perl-Test-Lib.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-Lib/perl-Test-Lib-0.002-1.fc33.src.rpm
Description:
Searches upward from the calling module for a directory t with a lib
directory inside it, and adds it to the module search path. Looks upward up
to 5 directories. This is intended to be used in test modules either
directly in t or in a subdirectory to find their included testing libraries
located in t/lib.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Petr Pisar 2021-04-20 10:03:33 UTC
URL and Source0 addresses are usable. Ok.
TODO: Update URL and Source0 to use MetaCPAN.

Source0 archive (SHA-512: d7fa4d12df49e51bb110f1bfb6973df7913bbe10335f93bb07774b2d49dcf52bad1807f07e9b053be2f8a2907a49ac638bae676297672e78c8f77824b2d7af62) is original. Ok.
Summary verified from lib/Test/Lib.pm. Ok.
Description verified from lib/Test/Lib.pm. Ok.
License verified from README, Makefile.PL, and lib/Test/Lib.pm. Ok.
No XS code, noArch BuildArch is Ok.
maint/Makefile.PL.include is not used. Ok.
Build-time dependencies are Ok.
All tests pass. Ok.

$ rpmlint perl-Test-Lib.spec ../SRPMS/perl-Test-Lib-0.002-1.fc35.src.rpm ../RPMS/noarch/perl-Test-Lib-0.002-1.fc35.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint output is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Test-Lib-0.002-1.fc35.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Apr 20 11:56 /usr/share/doc/perl-Test-Lib
-rw-r--r--    1 root     root                      200 Aug 16  2014 /usr/share/doc/perl-Test-Lib/Changes
-rw-r--r--    1 root     root                      839 Aug 16  2014 /usr/share/doc/perl-Test-Lib/README
-rw-r--r--    1 root     root                     1539 Apr 20 11:56 /usr/share/man/man3/Test::Lib.3pm.gz
drwxr-xr-x    2 root     root                        0 Apr 20 11:56 /usr/share/perl5/vendor_perl/Test
-rw-r--r--    1 root     root                     1667 Aug 16  2014 /usr/share/perl5/vendor_perl/Test/Lib.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Test-Lib-0.002-1.fc35.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.32.1)
      1 perl(Cwd)
      1 perl(File::Spec)
      1 perl(lib)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary Requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Test-Lib-0.002-1.fc35.noarch.rpm | sort -f | uniq -c
      1 perl(Test::Lib) = 0.002
      1 perl-Test-Lib = 0.002-1.fc35
Binary Provides are Ok.

$ resolvedeps f35-build ../RPMS/noarch/perl-Test-Lib-0.002-1.fc35.noarch.rpm
Binary dependencies are resolvable. Ok.

The package builds in F35 (https://koji.fedoraproject.org/koji/taskinfo?taskID=66322379). Ok.

The package is in line with Fedora and Perl packaging guidelines.
Please consider fixing the TODO item before building this package.
Resolution: Package APPROVED.

Comment 2 Emmanuel Seyman 2021-04-20 11:28:13 UTC
(In reply to Petr Pisar from comment #1)
>
> Please consider fixing the TODO item before building this package.

I've modified the URLs locally so this will be fixed on import.

> Resolution: Package APPROVED.

Thank you for the review, Petr. I've requested the repo.
https://pagure.io/releng/fedora-scm-requests/issue/33643

Comment 3 Gwyn Ciesla 2021-04-20 13:22:04 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-Lib

Comment 4 Emmanuel Seyman 2021-04-29 07:17:19 UTC
Built for rawhide a few days ago.


Note You need to log in before you can comment on or make changes to this bug.