Bug 1951479 - Review Request: perl-CLI-Osprey - MooX::Options + MooX::Cmd + Sanity
Summary: Review Request: perl-CLI-Osprey - MooX::Options + MooX::Cmd + Sanity
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: NotReady
Depends On: 1951040
Blocks: 1950798
TreeView+ depends on / blocked
 
Reported: 2021-04-20 08:56 UTC by Emmanuel Seyman
Modified: 2021-06-04 08:34 UTC (History)
2 users (show)

Fixed In Version: perl-CLI-Osprey-0.08-1.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-04 08:34:56 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+
emmanuel: needinfo+


Attachments (Terms of Use)

Description Emmanuel Seyman 2021-04-20 08:56:36 UTC
Spec URL: https://people.parinux.org/~seyman/fedora/perl-CLI-Osprey/perl-CLI-Osprey-0.08-1.fc33.src.rpm
SRPM URL: https://people.parinux.org/~seyman/fedora/perl-CLI-Osprey/perl-CLI-Osprey-0.08-1.fc33.src.rpm
Description:
CLI::Osprey is a module to assist in writing command-line applications with
M* OO modules (Moose, Moo, Mo). With it, you structure your app as one
or more modules, which get instantiated with the command-line arguments
as attributes. Arguments are parsed using Getopt::Long::Descriptive,
and both long and short help messages as well as complete manual pages
are automatically generated. An app can be a single command with
options, or have sub-commands (like git). Sub-commands can be defined
as modules (with options of their own) or as simple code-refs.

Fedora Account System Username: eseyman
Rpmlint Output:
perl-CLI-Osprey.src: W: spelling-error Summary(en_US) MooX -> Mo Ox, Moo X, Moon
perl-CLI-Osprey.src: W: spelling-error Summary(en_US) Cmd -> Cm, Cd, Cmdr
1 packages and 1 specfiles checked; 0 errors, 2 warnings.

Comment 1 Jitka Plesnikova 2021-05-04 11:08:40 UTC
Please add valid link for spec file.

Comment 3 Jitka Plesnikova 2021-05-04 18:31:06 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires 
FIX: Please add build-require
     perl(lib) - t/load-on-use.t:5
TODO: Add version constrain to 'perl(Module::Build::Tiny) >= 0.034'

$ rpm -qp --requires perl-CLI-Osprey-0.08-1.fc35.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(CLI::Osprey::Descriptive)
      1 perl(CLI::Osprey::Descriptive::Usage)
      1 perl(CLI::Osprey::InlineSubcommand)
      1 perl(Getopt::Long::Descriptive) >= 0.100
      1 perl(Getopt::Long::Descriptive::Usage)
      1 perl(:MODULE_COMPAT_5.32.1)
      1 perl(Module::Runtime)
      1 perl(Moo)
      1 perl(Moo::Role)
      1 perl(overload)
      1 perl(Path::Tiny)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(warnings)
Binary requires are almost Ok.
FIX: Please add run-require
     perl(Pod::Usage) - lib/CLI/Osprey/Role.pm:321

$ rpm -qp --provides perl-CLI-Osprey-0.08-1.fc35.noarch.rpm | sort | uniq -c
      1 perl(CLI::Osprey) = 0.08
      1 perl-CLI-Osprey = 0.08-1.fc35
      1 perl(CLI::Osprey::Descriptive) = 0.08
      1 perl(CLI::Osprey::Descriptive::Usage) = 0.08
      1 perl(CLI::Osprey::InlineSubcommand) = 0.08
      1 perl(CLI::Osprey::Role) = 0.08
Binary provides are Ok.

$ rpmlint ./perl-CLI-Osprey*
perl-CLI-Osprey.noarch: W: spelling-error Summary(en_US) MooX -> Mo Ox, Moo X, Moon
perl-CLI-Osprey.noarch: W: spelling-error Summary(en_US) Cmd -> Cm, Cd, Cmdr
perl-CLI-Osprey.src: W: spelling-error Summary(en_US) MooX -> Mo Ox, Moo X, Moon
perl-CLI-Osprey.src: W: spelling-error Summary(en_US) Cmd -> Cm, Cd, Cmdr
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Rpmlint is ok

Otherwise the package is in line with Fedora and Perl packaging guide lines.

Please correct all 'FIX' items and consider fixing 'TODO' item.

Resolution:
Approved

Comment 4 Emmanuel Seyman 2021-05-04 19:26:22 UTC
(In reply to Jitka Plesnikova from comment #3)
> 
> FIX: Please add build-require
>      perl(lib) - t/load-on-use.t:5

Fixed.

> TODO: Add version constrain to 'perl(Module::Build::Tiny) >= 0.034'

Fixed.

> FIX: Please add run-require
>      perl(Pod::Usage) - lib/CLI/Osprey/Role.pm:321

Fixed.

Spec URL: https://people.parinux.org/~seyman/fedora/perl-CLI-Osprey/perl-CLI-Osprey.spec
SRPM URL: https://people.parinux.org/~seyman/fedora/perl-CLI-Osprey/perl-CLI-Osprey-0.08-2.fc33.src.rpm

> Resolution:
> Approved

Thank you, Jikta. I've requested the repository:
https://pagure.io/releng/fedora-scm-requests/issue/33797

Comment 5 Gwyn Ciesla 2021-05-04 19:32:17 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-CLI-Osprey


Note You need to log in before you can comment on or make changes to this bug.