Bug 196275

Summary: system-settings.menu file vs. applications-merged dir
Product: [Fedora] Fedora Reporter: Ariszló <ariszlo>
Component: kdebaseAssignee: Than Ngo <than>
Status: CLOSED RAWHIDE QA Contact: Ben Levenson <benl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: imitev, rdieter, rstrode, triage
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: bzcl34nup
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-04-04 11:17:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 150225    
Attachments:
Description Flags
Sample Menu Entry with Categories=Music
none
patch to remove harmful code from MergeFiles none

Description Ariszló 2006-06-22 12:07:25 UTC
Description of problem:

Both the system-settings.menu of redhat-menus-6.7.5-1 and the
kde-applications.menu of kdelibs-3.5.1-2.3 contain this line

<DefaultMergeDirs/>

which may duplicate menu entries in K Menu.

Details

If you install kdemultimedia then you will have the following config file:

/etc/xdg/menus/applications-merged/kde-multimedia-music.menu

Say you also install a multimedia application with the following menu entry file:

##### /usr/share/applications/sample-menu-entry.desktop begins here
[Desktop Entry]
Name=Sample Menu Entry
Exec=konqueror
Type=Application
Categories=AudioVideo;Music;

##### /usr/share/applications/sample-menu-entry.desktop ends here (with a blank
line at the end)

Now, "Sample Menu Entry" will be listed in both Multimedia-Music and
Administration-Multimedia-Music.

The more submenus a package adds to the K Menu, the messier the Administration
menu becomes.

Version-Release number of selected component (if applicable): 6.7.5

How reproducible:

Easily reproducible. Just install kdemultimedia and copy
sample-menu-entry.desktop into /usr/share/applications/

Steps to Reproduce:
1. Install kdemultimedia to get the
/etc/xdg/menus/applications-merged/kde-multimedia-music.menu config file
2. Copy sample-menu-entry.desktop into /usr/share/applications/
  
Actual results:

"Sample Menu Entry" will be listed in both Multimedia-Music and
Administration-Multimedia-Music in K Menu.

Expected results:

It should only be listed in Multimedia-Music. Please remove the harmful
"<DefaultMergeDirs/>" line from system-settings.menu (and all other merge
files). Keep it only in kde-applications.menu (and applications.menu if necessary).

Additional info:

Comment 1 Ariszló 2006-06-22 12:07:25 UTC
Created attachment 131347 [details]
Sample Menu Entry with Categories=Music

Comment 2 Ariszló 2006-06-26 13:21:01 UTC
Created attachment 131541 [details]
patch to remove harmful code from MergeFiles

Comment 3 Ariszló 2006-10-28 14:55:29 UTC
Bug persists in redhat-menus-6.7.5-3 of Fedora Core 6. Is there anybody still
maintaining redhat-menus?

Comment 4 Ivan Mitev 2006-11-01 08:41:03 UTC
same problem, but the content of the submenu added in applications-shared
appears in both administration and in administration/server settings

that's quite annoying since we plan to do a mass deployment on 200+ machines,
and we'd rather not patch manually /etc/xdg/* and have these settings erased on
next redhat-menus rpm upgrade

btw, there are also some references to "applications.d" in the comments, which i
guess should be "applications-merged"

maybe rsrode@redhat doesn't work on that anymore, so if there's no reply we'll
try to contact someone from the redhat-menus' rpm changelog

Comment 5 Ray Strode [halfline] 2007-04-03 21:53:12 UTC
adding to FC7Target

Comment 6 Ray Strode [halfline] 2007-04-18 18:01:22 UTC
This seems like it would be a kde problem.

The spec says that <DefaultMergeDirs> is relative to the name of the file specified.

See the "File Locations" section of
http://standards.freedesktop.org/menu-spec/menu-spec-1.0.html

Comment 7 Ariszló 2007-04-18 22:07:23 UTC
I agree. Nevertheless, I cannot see why the <DefaultMergeDirs/> tags need be
included in the merge files in redhat-menus. All they do is show that KDE is
buggy. They are not used in GNOME because GNOME simply does not merge in any
information from any of the *-merged directories so they are not needed for
GNOME at all. If interpreted correctly, they would point to directories like
system-settings-merged, which either do not exist in Fedora or are just plain empty.

To summarize, the <DefaultMergeDirs/> tags in the merge files are not used by
GNOME, so they can be safely removed. They are only useful in debugging KDE,
which is probably not the main task of the redhat-menus package.

Comment 8 Ray Strode [halfline] 2007-04-18 22:10:01 UTC
They are used by 3rd party packages to customize the menu layout.  We've had to
move them around before to accomodate that.

Comment 9 Bug Zapper 2008-04-03 17:30:04 UTC
Based on the date this bug was created, it appears to have been reported
against rawhide during the development of a Fedora release that is no
longer maintained. In order to refocus our efforts as a project we are
flagging all of the open bugs for releases which are no longer
maintained. If this bug remains in NEEDINFO thirty (30) days from now,
we will automatically close it.

If you can reproduce this bug in a maintained Fedora version (7, 8, or
rawhide), please change this bug to the respective version and change
the status to ASSIGNED. (If you're unable to change the bug's version
or status, add a comment to the bug and someone will change it for you.)

Thanks for your help, and we apologize again that we haven't handled
these issues to this point.

The process we're following is outlined here:
http://fedoraproject.org/wiki/BugZappers/F9CleanUp

We will be following the process here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping to ensure this
doesn't happen again.

Comment 10 Ariszló 2008-04-04 05:16:54 UTC
Solved in KDE4.  See Bug 439378.