Bug 196617
| Summary: | Review Request: perl-File-chdir - Perl module for local chdir() | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ian Burrell <ianburrell> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | kevin:
fedora-cvs+
|
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-06-29 06:42:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779, 196627 | ||
|
Description
Ian Burrell
2006-06-26 01:45:13 UTC
I'm not sure why you have "CHECK(GPL or Artistic)" as the license. "GPL or Artistic" is correct. (Perhaps it's cpanspec doing that?) You should capitalize the summary. rpmlint complains about these: W: perl-File-chdir summary-not-capitalized a more sensible way to change directories W: perl-File-chdir invalid-license CHECK(GPL or Artistic) Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. X license field matches the actual license. * license is open source-compatible. License text not included upstream. * source files match upstream: 41a4661789f6de97fb632e4560d37864 File-chdir-0.06.tar.gz * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). X rpmlint is not silent * final provides and requires are sane: perl(File::chdir) = 0.06 perl(File::chdir::ARRAY) perl(File::chdir::SCALAR) perl-File-chdir = 0.06-1.fc6 = perl >= 0:5.004 perl(:MODULE_COMPAT_5.8.8) perl(Cwd) perl(Exporter) perl(File::Spec) perl(strict) perl(vars) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass: All tests successful. Files=3, Tests=48, 0 wallclock secs ( 0.08 cusr + 0.04 csys = 0.12 CPU) * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. By the way, it looks like you need to go through and fix the licenses and perhaps clean up the symmaries of the other spanspec-generated packages you've submitted. I'll be happy to review them all but I'll wait for cleaned-up versions first. I fixed the warnings. http://znark.com/fedora/perl-File-chdir.spec http://znark.com/fedora/perl-File-chdir-0.06-2.src.rpm Still builds fine and rpmlint is now quiet. The issues I had are fixed. APPROVED Added and built for devel. Package Change Request ====================== Package Name: perl-File-chdir New Branches: EL-4 EL-5 cvs done. |