Bug 1966769

Summary: Drop unnecessary findbugs dependency from libidn
Product: [Fedora] Fedora Reporter: Richard Fearn <richardfearn>
Component: libidnAssignee: Miroslav Lichvar <mlichvar>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: jorton, mlichvar, puntogil
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-06-02 08:12:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1964634    

Description Richard Fearn 2021-06-01 20:25:26 UTC
FindBugs upstream has been dead since 2016 and I would like to retire it from Fedora [1].

libidn currently has this dependency:

  BuildRequires: mvn(com.google.code.findbugs:annotations)

This seems to be because the libidn POM in java/pom.xml.in has this dependency:

      <dependency>
          <groupId>com.google.code.findbugs</groupId>
          <artifactId>annotations</artifactId>
          <version>2.0.1</version>
          <scope>provided</scope>
      </dependency>

That dependency can be downloaded here:

  https://search.maven.org/artifact/com.google.code.findbugs/annotations/2.0.1/jar

It provides classes in these packages:

  * edu.umd.cs.findbugs.annotations
  * javax.annotation (and subpackages)
  * net.jcip.annotations

All these packages contain the word "annotation". I can't see any reference to these packages in the libidn Java code:

  $ fedpkg sources
  
  $ tar -xf libidn-1.37.tar.gz
  
  $ cd libidn-1.37
  
  $ fgrep annotation $(find -name "*.java") | wc -l
  0

I think it's safe to remove the findbugs annotations dependency from libidn.

[1] https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/YI723NBFFXAOQSRMYIEFAD6CYGX7S6MM/

Comment 1 Richard Fearn 2021-06-01 20:27:51 UTC
For reference the findbugs annotation dependency was added to the libidn POM in this commit:

  https://git.savannah.gnu.org/gitweb/?p=libidn.git;a=commitdiff;h=2dfa483b59a8fe890553861ea0b04f594720bccc

Comment 2 Richard Fearn 2021-06-01 20:36:46 UTC
PR: https://src.fedoraproject.org/rpms/libidn/pull-request/3

Comment 3 Miroslav Lichvar 2021-06-02 08:12:40 UTC
Applied, thanks!

Comment 4 Richard Fearn 2021-06-02 18:42:18 UTC
Thanks for the super-quick response!