Bug 1966769 - Drop unnecessary findbugs dependency from libidn
Summary: Drop unnecessary findbugs dependency from libidn
Alias: None
Product: Fedora
Classification: Fedora
Component: libidn
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Miroslav Lichvar
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 1964634
TreeView+ depends on / blocked
Reported: 2021-06-01 20:25 UTC by Richard Fearn
Modified: 2021-06-02 18:42 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2021-06-02 08:12:40 UTC
Type: Bug

Attachments (Terms of Use)

Description Richard Fearn 2021-06-01 20:25:26 UTC
FindBugs upstream has been dead since 2016 and I would like to retire it from Fedora [1].

libidn currently has this dependency:

  BuildRequires: mvn(com.google.code.findbugs:annotations)

This seems to be because the libidn POM in java/pom.xml.in has this dependency:


That dependency can be downloaded here:


It provides classes in these packages:

  * edu.umd.cs.findbugs.annotations
  * javax.annotation (and subpackages)
  * net.jcip.annotations

All these packages contain the word "annotation". I can't see any reference to these packages in the libidn Java code:

  $ fedpkg sources
  $ tar -xf libidn-1.37.tar.gz
  $ cd libidn-1.37
  $ fgrep annotation $(find -name "*.java") | wc -l

I think it's safe to remove the findbugs annotations dependency from libidn.

[1] https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/YI723NBFFXAOQSRMYIEFAD6CYGX7S6MM/

Comment 1 Richard Fearn 2021-06-01 20:27:51 UTC
For reference the findbugs annotation dependency was added to the libidn POM in this commit:


Comment 2 Richard Fearn 2021-06-01 20:36:46 UTC
PR: https://src.fedoraproject.org/rpms/libidn/pull-request/3

Comment 3 Miroslav Lichvar 2021-06-02 08:12:40 UTC
Applied, thanks!

Comment 4 Richard Fearn 2021-06-02 18:42:18 UTC
Thanks for the super-quick response!

Note You need to log in before you can comment on or make changes to this bug.