Bug 1966790
| Summary: | Drop unnecessary findbugs dependency from nom-tam-fits | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard Fearn <richardfearn> |
| Component: | nom-tam-fits | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | lupinix.fedora, puntogil, zbyszek |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | nom-tam-fits-1.15.2-7.fc35 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-06-02 07:08:25 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1964634 | ||
Built in rawhide. Thanks for the super-quick response! |
FindBugs upstream has been dead since 2016 and I would like to retire it from Fedora [1]. nom-tam-fits currently has this dependency: BuildRequires: mvn(com.google.code.findbugs:annotations) This is due to this dependency in the nom-tam-fits POM: <dependency> <groupId>com.google.code.findbugs</groupId> <artifactId>annotations</artifactId> <version>3.0.0</version> <scope>provided</scope> </dependency> That dependency can be downloaded here: https://search.maven.org/artifact/com.google.code.findbugs/annotations/3.0.0/jar It provides classes in these packages: * edu.umd.cs.findbugs.annotations * javax.annotation (and subpackages) * net.jcip.annotations All these packages contain the word "annotation". Searching the nom-tam-fits source for "annotation", I can only see usage of the SuppressFBWarnings annotation. I saw this note in src/assembly/BUILD.txt: The Annotation jar is only needed for compilation. If you delete all lines with SuppressFBWarnings from the source code you can dispense with it altogether. It is used to suppress warning messages in some of the diagnostic tools. I propose doing exactly that. [1] https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/YI723NBFFXAOQSRMYIEFAD6CYGX7S6MM/