Bug 1966790 - Drop unnecessary findbugs dependency from nom-tam-fits
Summary: Drop unnecessary findbugs dependency from nom-tam-fits
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: nom-tam-fits
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1964634
TreeView+ depends on / blocked
 
Reported: 2021-06-01 20:58 UTC by Richard Fearn
Modified: 2021-06-02 18:42 UTC (History)
3 users (show)

Fixed In Version: nom-tam-fits-1.15.2-7.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-02 07:08:25 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Richard Fearn 2021-06-01 20:58:40 UTC
FindBugs upstream has been dead since 2016 and I would like to retire it from Fedora [1].

nom-tam-fits currently has this dependency:

  BuildRequires: mvn(com.google.code.findbugs:annotations)

This is due to this dependency in the nom-tam-fits POM:

    <dependency>
        <groupId>com.google.code.findbugs</groupId>
        <artifactId>annotations</artifactId>
        <version>3.0.0</version>
        <scope>provided</scope>
    </dependency>

That dependency can be downloaded here:

  https://search.maven.org/artifact/com.google.code.findbugs/annotations/3.0.0/jar

It provides classes in these packages:

  * edu.umd.cs.findbugs.annotations
  * javax.annotation (and subpackages)
  * net.jcip.annotations

All these packages contain the word "annotation". Searching the nom-tam-fits source for "annotation", I can only see usage of the SuppressFBWarnings annotation.

I saw this note in src/assembly/BUILD.txt:

  The Annotation jar is only needed for compilation.  If
  you delete all lines with SuppressFBWarnings from the source code
  you can dispense with it altogether.  It is used to suppress warning
  messages in some of the diagnostic tools.

I propose doing exactly that.

[1] https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/YI723NBFFXAOQSRMYIEFAD6CYGX7S6MM/

Comment 2 Zbigniew Jędrzejewski-Szmek 2021-06-02 07:08:25 UTC
Built in rawhide.

Comment 3 Richard Fearn 2021-06-02 18:42:36 UTC
Thanks for the super-quick response!


Note You need to log in before you can comment on or make changes to this bug.