Bug 197413 (php-pear-Net-Curl)
Summary: | Review Request: php-pear-Net-Curl - OO interface to PHP's cURL extension | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christopher Stone <chris.stone> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | wtogami:
fedora-cvs+
|
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-09-08 02:33:46 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 197420 |
Description
Christopher Stone
2006-07-01 05:20:22 UTC
Hmm, it looks like you install the LICENSE file in %prep, but it doesn't seem to make it into the final package. * source files match upstream: 6a26900c1111336aa45615d4a3a4f66a Net_Curl-1.2.3.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * rpmlint is silent (except for the usual bogus dangerous-command warning) * final provides and requires are sane: php-pear(Net_Curl) = 1.2.3 php-pear-Net-Curl = 1.2.3-1.fc6 = /bin/sh /usr/bin/pear php-pear(PEAR) * %check is not present; no test suite upstream. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (PEAR module installation) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. SPEC: http://tkmame.retrogames.com/fedora-extras/php-pear-Net-Curl.spec SRPM: http://tkmame.retrogames.com/fedora-extras/php-pear-Net-Curl-1.2.3-2.src.rpm %changelog * Thu Sep 07 2006 Christopher Stone <chris.stone> 1.2.3-2 - Add LICENSE file to %%doc Looks good now. APPROVED Package Change Request ====================== Package Name: php-pear-Net-Curl New Branches: EL-5 |