This service will be undergoing maintenance at 00:00 UTC, 2017-10-23 It is expected to last about 30 minutes
Bug 197420 - (pear-Payment-Process) Review Request: php-pear-Payment-Process - Unified payment processor
Review Request: php-pear-Payment-Process - Unified payment processor
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Package Reviews List
:
Depends On: php-pear-XML-Parser php-pear-Net-Curl php-pear-Validate Validate-Finance-CC
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2006-07-01 02:03 EDT by Christopher Stone
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-09-09 12:08:50 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
jwboyer: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Christopher Stone 2006-07-01 02:03:00 EDT
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Payment-Process.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Payment-Process-0.6.5-1.src.rpm

Description:
Payment_Process is a gateway-independent framework for processing credit
cards, e-checks and eventually other forms of payments as well.
Comment 1 Jason Tibbitts 2006-09-09 11:03:35 EDT
I guess you have a redundant Requires: php there.

* source files match upstream:
   d63b822c194775f5dd3cbd23fb500322  Payment_Process-0.6.5.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent (except for that bogus warning)
* final provides and requires are sane:
   php-pear(Payment_Process) = 0.6.5
   php-pear-Payment-Process = 0.6.5-1.fc6
  =
   /bin/sh
   /usr/bin/pear
?  php
   php-pear(Net_Curl) >= 1.2.0
   php-pear(PEAR)
   php-pear(Validate) >= 0.5.0
   php-pear(Validate_Finance_CreditCard) >= 0.5.0
   php-pear(XML_Parser) >= 1.2.6
* %check is not present; no test suite upstream.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets OK (PEAR module installation)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED
Comment 2 Christopher Stone 2007-05-01 23:06:57 EDT
Package Change Request
======================
Package Name: php-pear-Payment-Process
New Branches: EL-5

Note You need to log in before you can comment on or make changes to this bug.