Bug 197821

Summary: Review Request: perl-IO-Socket-INET6
Product: [Fedora] Fedora Reporter: Warren Togami <wtogami>
Component: Package ReviewAssignee: David Cantrell <dcantrell>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-07-12 15:32:06 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On: 197874    
Bug Blocks: 188268    

Description Warren Togami 2006-07-06 13:27:06 EDT
Spec URL: http://togami.com/~warren/fedora/perl-IO-Socket-INET6.spec
SRPM URL: http://togami.com/~warren/fedora/perl-IO-Socket-INET6-2.51-1.src.rpm
Description: Perl Object interface for AF_INET|AF_INET6 domain sockets

Spamassassin requires this in order to support IPv6.
Comment 1 Ralf Corsepius 2006-07-06 14:58:26 EDT
Some comments:

* Source0 should be a URL

* rpmbuild -ba perl-IO-Socket-INET6.spec
Warning: prerequisite Socket6 0.12 not found

Probably a missing BR: perl(Socket6)

* Package is noarch 
=> passing OPTIMIZE to Makefile.PL is superfluous
=>  "find $RPM_BUILD_ROOT -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'"
probably also is not necessary.
Comment 3 Jesse Keating 2006-07-10 13:33:56 EDT
Package looks good.

rpmlint is silent on the srpm.  Above fixes have been integrated.  Package
builds in mock (once Socket6 is put in the buildroot)