Bug 197821 - Review Request: perl-IO-Socket-INET6
Summary: Review Request: perl-IO-Socket-INET6
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Cantrell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 197874
Blocks: FC-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-07-06 17:27 UTC by Warren Togami
Modified: 2013-01-10 01:26 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-12 19:32:06 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Warren Togami 2006-07-06 17:27:06 UTC 
Spec URL: http://togami.com/~warren/fedora/perl-IO-Socket-INET6.spec
SRPM URL: http://togami.com/~warren/fedora/perl-IO-Socket-INET6-2.51-1.src.rpm
Description: Perl Object interface for AF_INET|AF_INET6 domain sockets

Spamassassin requires this in order to support IPv6.
Comment 1 Ralf Corsepius 2006-07-06 18:58:26 UTC 
Some comments:

* Source0 should be a URL

* rpmbuild -ba perl-IO-Socket-INET6.spec
...
Warning: prerequisite Socket6 0.12 not found

Probably a missing BR: perl(Socket6)


* Package is noarch 
=> passing OPTIMIZE to Makefile.PL is superfluous
=>  "find $RPM_BUILD_ROOT -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'"
probably also is not necessary.
Comment 2 Warren Togami 2006-07-06 20:05:25 UTC 
http://togami.com/~warren/fedora/perl-IO-Socket-INET6.spec
http://togami.com/~warren/fedora/perl-IO-Socket-INET6-2.51-2.src.rpm

Added your changes.
Comment 3 Jesse Keating 2006-07-10 17:33:56 UTC 
Package looks good.

rpmlint is silent on the srpm.  Above fixes have been integrated.  Package
builds in mock (once Socket6 is put in the buildroot)

Approving.
Note You need to log in before you can comment on or make changes to this bug.