Bug 198246

Summary:	Review Request: ORBit
Product:	[Fedora] Fedora	Reporter:	Paul Howarth <paul>
Component:	Package Review	Assignee:	Michael J Knox <michael>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	rdieter
Target Milestone:	---	Flags:	kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-07-21 12:58:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 198245

Description Paul Howarth 2006-07-10 15:31:22 UTC

Spec URL: http://www.city-fan.org/~paul/extras/Gnome-1/ORBit.spec
SRPM URL: http://www.city-fan.org/~paul/extras/Gnome-1/ORBit-0.5.17-17.src.rpm
Description:

ORBA Object Request Broker for GNOME-1 compatibility

This package was removed from Core for FC6 and I am submitting it to Extras to support the people that still need it for legacy applications. I pulled the package from Core CVS and then tweaked it for Extras and to suit my own cosmetic preferences. Reviewers may consider using rpmdiff to compare the built packages with the versions in Fedora Core 5.

Comment 1 Rex Dieter 2006-07-10 16:10:21 UTC

Since -devel has files in %{_libdir}/pkgconfig and %_datadir/aclocal, to avoid 
possible unowned dirs, it should:
Requires: pkgconfig
and
Requires: automake
(or Requires: %_datadir/aclocal)
respectively.

Comment 2 Paul Howarth 2006-07-10 17:01:36 UTC

(In reply to comment #1)
> Since -devel has files in %{_libdir}/pkgconfig and %_datadir/aclocal, to avoid 
> possible unowned dirs, it should:
> Requires: pkgconfig
> and
> Requires: automake
> (or Requires: %_datadir/aclocal)
> respectively.

Fixed in -18:

Spec URL: http://www.city-fan.org/~paul/extras/Gnome-1/ORBit.spec
SRPM URL: http://www.city-fan.org/~paul/extras/Gnome-1/ORBit-0.5.17-18.src.rpm

Comment 3 Michael J Knox 2006-07-21 04:31:35 UTC

Hey, I will review this puppy for you... 

----------------------------------------
Review for release 18:

* RPM name is OK
* Source ORBit-0.5.17.tar.bz2 is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint of ORBit-devel looks OK
* rpmlint of ORBit looks OK
* File list of ORBit-devel looks OK
* File list of ORBit looks OK

Notes:

Looks good, I see no reason why this can't be imported. Consider it APPROVED. 

Please remember to close this review once the package has been imported into CVS.

Comment 4 Paul Howarth 2006-07-21 12:58:37 UTC

Package imported and added to owners.list.

 12853 (ORBit): Build on target fedora-development-extras succeeded.
     Build logs may be found at
http://buildsys.fedoraproject.org/logs/fedora-development-extras/12853-ORBit-0.5.17-18.fc6/

Thanks for the review.

Comment 5 Paul Howarth 2010-05-10 12:26:16 UTC

Package Change Request
======================
Package Name: ORBit
New Branches: EL-6
Owners: pghmcfc

ORBit has been dropped from EL-6 but was present in earlier EL releases.

Comment 6 Paul Howarth 2010-05-10 12:29:23 UTC

Actually, forget that branch request - I don't need it after all.

Comment 7 Paul Howarth 2010-07-09 10:22:04 UTC

Package Change Request
======================
Package Name: ORBit
New Branches: EL-6
Owners: pghmcfc

ORBit has been dropped from EL-6 but was present in earlier EL releases.
The Gnome-1 libraries are wanted by the Fedora Astronomy group for the "spacechart" package.

Comment 8 Kevin Fenzi 2010-07-09 18:04:19 UTC

CVS done (by process-cvs-requests.py).