Bug 198289
| Summary: | Review Request: python-paste-script - A pluggable command-line frontend | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Luke Macken <lmacken> |
| Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dcallagh, pertusus, pfrields |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-08-21 17:16:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779, 189338, 198287, 198288 | ||
|
Description
Luke Macken
2006-07-10 20:50:22 UTC
rpmlint:
E: python-pastescript zero-length
/usr/lib/python2.4/site-packages/PasteScript-0.9-py2.4.egg-info/not-zip-safe
Ignore.
W: python-pastescript doc-file-dependency
/usr/share/doc/python-pastescript-0.9/docs/example_cgi_app.ini /usr/bin/env
W: python-pastescript doc-file-dependency
/usr/share/doc/python-pastescript-0.9/docs/example_wsgiutils_app.ini /usr/bin/env
Many python scripts require this, ignore.
About the name, upstream does use capitals when refering to Paste Script,
however Debian also does python-pastescript, I'm inclined to follow along.
* Uses both $RPM_BUILD_ROOT and %{buildroot}. Still readable but easily fixed on
next commit.
Good:
+ builds on devel x86_64
+ uses setuptools
+ license (MIT)
+ noarch
+ sources match upstream
+ sitelib macro
+ follows python templates for macros and file listing script
+ proper %clean
+ macro usage throughout
+ file permissions and ownership
Nearly ready for approval, but let's get resolution on the naming issue. See
also python-pastedeploy, bug #198288
The Packaging Committee discussed this naming briefly on the fedora-packaging mailing list and decided that it was the maintainer's discretion how to format this portion of the package name. Some upstream packages might name their packages a specific way (pastescript.tar.gz or paste-scripts.tar.gz) in which case it would be good to following upstream's lead is a good indicator. But the maintainer has final say as to what makes the most sense. FWIW, Debian seems to have adopted the same policy, with some packages with a dash (python-twisted-conch) and others not (python-pastescript). Thanks for looking into the naming issue Toshio. http://people.redhat.com/lmacken/python-paste-script-0.9-3.src.rpm http://people.redhat.com/lmacken/python-paste-script.spec * Sat Jul 29 2006 Luke Macken <lmacken> - 0.9-3 - Require python-paste-deploy * Wed Jul 26 2006 Luke Macken <lmacken> - 0.9-2 - Rename to python-paste-script - Use consistent buildroot variables - Fix docs inclusion http://people.redhat.com/lmacken/python-paste-script-0.9-4.src.rpm http://people.redhat.com/lmacken/python-paste-script.spec * Mon Aug 21 2006 Luke Macken <lmacken> - 0.9-4 - Include .pyo files instead of ghosting them. Looks fine, builds fine, see review in comment 1. APPROVED Imported into CVS, added to owners.list, requested FC-5 CVS branch, tagged and built for devel. Thanks! Changed summary for tracking purposes. Please un-retire the epel7 branch. Package Change Request ====================== Package Name: python-paste-script New Branches: epel7 Owners: dcallagh Complete. |