Red Hat Bugzilla – Bug 198289
Review Request: python-paste-script - A pluggable command-line frontend
Last modified: 2016-09-19 22:37:20 EDT
Spec URL: http://people.redhat.com/lmacken/python-pastescript.spec SRPM URL: http://people.redhat.com/lmacken/python-pastescript-0.9-1.src.rpm Description: Paster is pluggable command-line frontend, including commands to setup package file layouts Built-in features: * Creating file layouts for packages. For instance a setuptools-ready file layout. * Serving up web applications, with configuration based on paste.deploy
rpmlint: E: python-pastescript zero-length /usr/lib/python2.4/site-packages/PasteScript-0.9-py2.4.egg-info/not-zip-safe Ignore. W: python-pastescript doc-file-dependency /usr/share/doc/python-pastescript-0.9/docs/example_cgi_app.ini /usr/bin/env W: python-pastescript doc-file-dependency /usr/share/doc/python-pastescript-0.9/docs/example_wsgiutils_app.ini /usr/bin/env Many python scripts require this, ignore. About the name, upstream does use capitals when refering to Paste Script, however Debian also does python-pastescript, I'm inclined to follow along. * Uses both $RPM_BUILD_ROOT and %{buildroot}. Still readable but easily fixed on next commit. Good: + builds on devel x86_64 + uses setuptools + license (MIT) + noarch + sources match upstream + sitelib macro + follows python templates for macros and file listing script + proper %clean + macro usage throughout + file permissions and ownership Nearly ready for approval, but let's get resolution on the naming issue. See also python-pastedeploy, bug #198288
The Packaging Committee discussed this naming briefly on the fedora-packaging mailing list and decided that it was the maintainer's discretion how to format this portion of the package name. Some upstream packages might name their packages a specific way (pastescript.tar.gz or paste-scripts.tar.gz) in which case it would be good to following upstream's lead is a good indicator. But the maintainer has final say as to what makes the most sense. FWIW, Debian seems to have adopted the same policy, with some packages with a dash (python-twisted-conch) and others not (python-pastescript).
Thanks for looking into the naming issue Toshio. http://people.redhat.com/lmacken/python-paste-script-0.9-3.src.rpm http://people.redhat.com/lmacken/python-paste-script.spec * Sat Jul 29 2006 Luke Macken <lmacken@redhat.com> - 0.9-3 - Require python-paste-deploy * Wed Jul 26 2006 Luke Macken <lmacken@redhat.com> - 0.9-2 - Rename to python-paste-script - Use consistent buildroot variables - Fix docs inclusion
http://people.redhat.com/lmacken/python-paste-script-0.9-4.src.rpm http://people.redhat.com/lmacken/python-paste-script.spec * Mon Aug 21 2006 Luke Macken <lmacken@redhat.com> - 0.9-4 - Include .pyo files instead of ghosting them.
Looks fine, builds fine, see review in comment 1. APPROVED
Imported into CVS, added to owners.list, requested FC-5 CVS branch, tagged and built for devel. Thanks!
Changed summary for tracking purposes.
Please un-retire the epel7 branch. Package Change Request ====================== Package Name: python-paste-script New Branches: epel7 Owners: dcallagh
Complete.