Bug 2022179
| Summary: | Review Request: rust-hidapi - Rust-y wrapper around hidapi | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Link Dupont <link> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-12-11 01:29:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2022176, 2022178 | ||
|
Description
Link Dupont
2021-11-11 01:50:32 UTC
Taking this review. There seems to be a couple things wrong with this crate package: * The build dependency "libusb-devel" is wrong, as the crate sources don't actually ask for libusb-0.1 at all (it wants libusb1 instead) * The default feature set in cargo can't be used since we don't ship the static library for hidraw or libusb1 This crate needs work to be packaged properly. The following things need to happen here: * The "static" feature subpackages need to be removed, as we don't have the static libraries for them * The crate's "default" feature set needs to be changed to "LINUX_SHARED_HIDRAW" in the Cargo.toml: https://github.com/ruabmbua/hidapi-rs/blob/master/Cargo.toml * The "static" features in Cargo.toml need to be removed, so that we don't generate dependencies for them * The BuildRequires needs to be switched to "pkgconfig(hidapi-hidraw)" * The +linux-shared-hidraw-devel subpackage needs "Requires: pkgconfig(hidapi-hidraw)" * The +linux-shared-libusb-devel subpackage needs "Requires: pkgconfig(hidapi-libusb)" Fixed up these issues in this new spec. I'm not sure if there's a more Cargo-native way to disable the linux-static-hidraw feature; I just patched it out of the Cargo.toml. Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02958205-rust-hidapi/rust-hidapi.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02958205-rust-hidapi/rust-hidapi-1.2.6-1.fc36.src.rpm Fedora Review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02958205-rust-hidapi/fedora-review Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-hidapi FEDORA-2021-01f7520709 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709 FEDORA-2021-01f7520709 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-01f7520709 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-01f7520709 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709 FEDORA-2021-01f7520709 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-01f7520709 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-01f7520709 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. |