Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02875008-rust-system76_ectool/rust-system76_ectool.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02875008-rust-system76_ectool/rust-system76_ectool-0.3.6-1.fc36.src.rpm Description: Tool for interacting with System76 embedded controller firmware devices. Fedora Account System Username: linkdupont Fedora Review: https://copr-be.cloud.fedoraproject.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02875008-rust-system76_ectool/fedora-review/
Taking this review.
> BuildRequires: pkgconfig(libudev) This should be changed to use the "linux-shared-hidraw" feature instead in the Cargo.toml: https://github.com/system76/ec/blob/55523d408353b9553dcfd0547f65c10dc10ae386/tool/Cargo.toml#L21 That will also let you drop the libudev-devel BR here since the changes I requested in bug 2022179 will propagate up the needed build dependencies.
I've filed this as an upstream ticket as well: https://github.com/system76/ec/issues/257
Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02958309-rust-system76_ectool/rust-system76_ectool.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02958309-rust-system76_ectool/rust-system76_ectool-0.3.6-1.fc36.src.rpm Fedora Review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02958309-rust-system76_ectool/fedora-review
Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - executables produced with correct binary subpackage - devel subpackage with sources packaged correctly for usage as a crate - builds and installs PACKAGE APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-system76_ectool
FEDORA-2021-01f7520709 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
FEDORA-2021-01f7520709 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-01f7520709 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-01f7520709 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.