(In reply to Link Dupont from comment #0)
> Spec URL:
> https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-
> rawhide-x86_64/02948977-system76-keyboard-configurator/system76-keyboard-
> configurator.spec
> SRPM URL:
> https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-
> rawhide-x86_64/02948977-system76-keyboard-configurator/system76-keyboard-
> configurator-1.0.0-1.fc36.src.rpm

These links are broken.

Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02950631-system76-keyboard-configurator/system76-keyboard-configurator.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02950631-system76-keyboard-configurator/system76-keyboard-configurator-1.0.0-1.20211111git38c1c7b.fc36.src.rpm

(In reply to Maxwell G from comment #1)
> These links are broken.

Yes, thank you for pointing that out. A number of my review bugs will have missing links at this point; I had to rebuild some of them.

> Requires:      %{name} == %{version}-%{release}

I'm not sure "==" is valid, I think you need to use "=" instead.

(In reply to Neal Gompa from comment #4)
> > Requires:      %{name} == %{version}-%{release}
> 
> I'm not sure "==" is valid, I think you need to use "=" instead.

Oops. You're right. Good catch.

> BuildRequires: libudev-devel
> BuildRequires: hidapi-devel
> [...]
> BuildRequires: (crate(hidapi/linux-static-hidraw) >= 1.2.0 with crate(hidapi/linux-static-hidraw) < 2.0.0~)

This should be changed to use the "linux-shared-hidraw" feature instead in the backend Cargo.toml: https://github.com/pop-os/keyboard-configurator/blob/666266c60c89186b829efdfb061f7cde1271deb5/backend/Cargo.toml#L12

That will also let you drop hidapi-devel BR here (and probably libudev-devel BR too) since the changes I requested in bug 2022179 will propagate up the needed build dependencies.

Taking this review.

I've filed this as an upstream ticket as well: https://github.com/pop-os/keyboard-configurator/issues/107

Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02958414-system76-keyboard-configurator/system76-keyboard-configurator.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02958414-system76-keyboard-configurator/system76-keyboard-configurator-1.0.0-1.20211111git38c1c7b.fc36.src.rpm
Fedora Review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02958414-system76-keyboard-configurator/fedora-review

> %package devel
>
> Summary:       Development files for %{name}
> Requires:      %{name} = %{version}-%{release}
>
> %description devel
> Development files for configuration of System76 keyboard firmware.

This has no file list section, is this intentional? If so, should this be deleted?

> %forgesetup
> %patch0 -p1
> %patch1 -p1

This can be "%forgeautosetup -p1" instead.

Fixed!

Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02971574-system76-keyboard-configurator/system76-keyboard-configurator.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02971574-system76-keyboard-configurator/system76-keyboard-configurator-1.0.0-1.20211111git38c1c7b.fc36.src.rpm
Fedora review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02971574-system76-keyboard-configurator/fedora-review

Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- executable produced with correct binary subpackage
- builds and installs

PACKAGE APPROVED.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/system76-keyboard-configurator

FEDORA-2021-01f7520709 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709

FEDORA-2021-01f7520709 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-01f7520709 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2021-01f7520709 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709

FEDORA-2021-01f7520709 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-01f7520709 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2021-01f7520709 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.