Bug 2034225

Summary:	Review Request: rust-scrypt - Scrypt password-based key derivation function
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Michel Lind <michel>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	michel, package-review
Target Milestone:	---	Flags:	michel: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-01-11 18:19:31 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2031925, 2034218, 2034224
Bug Blocks:	2034226

Description Fabio Valentini 2021-12-20 12:38:20 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-scrypt.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-scrypt-0.8.0-1.fc35.src.rpm

Description:
Scrypt password-based key derivation function.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2021-12-20 12:39:58 UTC

Note: Not packaging the latest version is intentional.

The reason I am packaging this crate is that version 0.8.0 of this crate appears in the dependency tree of rust-rsa 0.5.0, which I am working on updating, and version 0.8.1 depends on versions of dependencies that are too new right now. I will update the crate, once that is possible.

Comment 2 Michel Lind 2022-01-11 03:40:53 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- X latest version of the crate is packaged => explanation given
- license matches upstream specification (MIT or ASL 2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 3 Fabio Valentini 2022-01-11 10:53:56 UTC

Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/40763
https://pagure.io/releng/fedora-scm-requests/issue/40764
https://pagure.io/releng/fedora-scm-requests/issue/40765

Comment 4 Gwyn Ciesla 2022-01-11 15:12:13 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-scrypt

Comment 5 Fabio Valentini 2022-01-11 18:19:31 UTC

Built and submitted for all current Fedora branches:

https://bodhi.fedoraproject.org/updates/FEDORA-2022-ea96da3bb8
https://bodhi.fedoraproject.org/updates/FEDORA-2022-e1f4d8e186
https://bodhi.fedoraproject.org/updates/FEDORA-2022-cad35cb159