Bug 2035544

Summary:	Review Request: rust-coolor - Conversion between color formats
Product:	[Fedora] Fedora	Reporter:	Davide Cavalca <davide>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-01-05 10:15:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2035546

Description Davide Cavalca 2021-12-24 15:17:48 UTC

Spec URL: https://dcavalca.fedorapeople.org/review/rust-coolor/rust-coolor.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-coolor/rust-coolor-0.3.1-1.fc36.src.rpm

Description:
Conversion between color formats.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2021-12-24 15:17:50 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=80420714

Comment 2 Fabio Valentini 2021-12-30 18:55:04 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Note: There's some image files in /doc and the bacon.toml file that might not be necessary, or a good idea to ship in the -devel package.

I recommend you either add an 'exclude = ["/doc", "/bacon.toml"]' line to Cargo.toml with your patch as well, or add an %exclude to the -devel package's %files list for them.

===

Recommended post-import rust-sig tasks:

- add package to rust-sig with "commit" access

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 3 Fabio Valentini 2021-12-30 18:55:47 UTC

(Could you review one of my packages in return?
https://bugzilla.redhat.com/show_bug.cgi?id=2031925 )

Comment 4 Davide Cavalca 2021-12-31 08:15:53 UTC

Thanks!

$ fedpkg request-repo rust-coolor 2035544
https://pagure.io/releng/fedora-scm-requests/issue/40334

Comment 5 Gwyn Ciesla 2022-01-04 15:18:46 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-coolor

Comment 6 Fedora Update System 2022-01-05 10:12:48 UTC

FEDORA-2022-b5210812ea has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b5210812ea

Comment 7 Fedora Update System 2022-01-05 10:15:01 UTC

FEDORA-2022-b5210812ea has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.