Bug 2036109
| Summary: | Review Request: intel-cm-compiler - Intel(R) C for Metal compiler | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | František Zatloukal <fzatlouk> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | dominik, ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | intel-cm-compiler-1.0.119-1.fc36 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-01-22 17:57:53 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2036104, 2036105, 2036106 | ||
| Bug Blocks: | 1942132 | ||
|
Description
František Zatloukal
2021-12-29 18:11:25 UTC
SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03207186-intel-cm-compiler/intel-cm-compiler.spec SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03207186-intel-cm-compiler/intel-cm-compiler-1.0.119-1.fc36.src.rpm SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03210855-intel-cm-compiler/intel-cm-compiler.spec SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03210855-intel-cm-compiler/intel-cm-compiler-1.0.119-1.fc36.src.rpm > %{_includedir}/cm/*
You can take the asterisk off, then RPM will also ensure the package owns the directory and all the content under it.
Review notes: * Packaging complies with the guidelines * Package builds and installs * No serious issues from rpmlint * Licensing is correct and license files are correctly installed You can fix the one issue I noticed on import, so... PACKAGE APPROVED. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/intel-cm-compiler Built in rawhide: intel-cm-compiler-1.0.119-1.fc36 @ngompa13 you missed a couple of things:
%{_libdir}/libclangFEWrapper.so.*
This allows unnoticed SONAME bumps and is not permitted.
LICENSE.TXT should be in -libs, because it's possible to install -libs separately and it won't include the license text as required.
Also, there's an empty %doc in -devel.
@
One more thing. I'd use rm -rv instead of rm -rf. With the latter, you won't notice if some of the things you're deleting are no longer there, while the former tells you what you deleted. Thanks! It should be addressed by intel-cm-compiler-1.0.119-2.fc36 ; as for rm -rf, I'll prefer to leave it as it is. It seems anyway that any upstream update will require poking the package with stick until it starts working, so... :D |