FYI: Just found out I'll need to add date/shortcommit into the nvr as it's a git snapshot really.

SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03140537-spirv-llvm8.0-translator/spirv-llvm8.0-translator.spec

SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03140537-spirv-llvm8.0-translator/spirv-llvm8.0-translator-8-1.20211223gita44863e.fc36.src.rpm

> Source0:        https://github.com/KhronosGroup/SPIRV-LLVM-Translator/archive/%{commit}/%{upstream_name}-%{shortcommit}.tar.gz

Please use proper SourceURL form as proscribed in the Guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags
In this case, that'd be "%{url}/archive/%{commit}/%{upstream_name}-%{shortcommit}.tar.gz"

SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03198536-spirv-llvm8.0-translator/spirv-llvm8.0-translator.spec

SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03198536-spirv-llvm8.0-translator/spirv-llvm8.0-translator-8-1.20211223gita44863e.fc36.src.rpm

(In reply to Jun.Miao from comment #3)
> > Source0:        https://github.com/KhronosGroup/SPIRV-LLVM-Translator/archive/%{commit}/%{upstream_name}-%{shortcommit}.tar.gz
> 
> Please use proper SourceURL form as proscribed in the Guidelines:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
> #_git_tags
> In this case, that'd be
> "%{url}/archive/%{commit}/%{upstream_name}-%{shortcommit}.tar.gz"

Addressed, added license into the package.

Taking this review.

>        -DLLVM_DIR=/usr/lib64/llvm8.0/lib/cmake/llvm \


This should use %{_libdir} rather than hardcoded /usr/lib64.

SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03204358-spirv-llvm8.0-translator/spirv-llvm8.0-translator.spec

SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03204358-spirv-llvm8.0-translator/spirv-llvm8.0-translator-8-1.20211223gita44863e.fc36.src.rpm

Review notes:

* Packaging complies with the guidelines
* Package builds and installs
* No serious issues from rpmlint
* Licensing is correct and license files are correctly installed

PACKAGE APPROVED.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/spirv-llvm8.0-translator

Built in rawhide: spirv-llvm8.0-translator-8-1.20211223gita44863e.fc36

@fzatlouk please don't use globs for SONAMEs, you might miss SONAME bumps:

https://src.fedoraproject.org/rpms/spirv-llvm8.0-translator/blob/rawhide/f/spirv-llvm8.0-translator.spec#_74
%{_libdir}/libLLVMSPIRVLib.so.*

	
%files devel
%dir %{_includedir}/LLVMSPIRVLib/
%{_includedir}/LLVMSPIRVLib/

The %dir line is redundant.

Thanks, should be addressed in spirv-llvm8.0-translator-8-2.20211223gita44863e.fc36 . The soname bump is technically impossible here, since it's just equal to llvm8.0 major, which will always be 8. Changed it though, there is no harm in doing that.