SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03207186-intel-cm-compiler/intel-cm-compiler.spec

SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03207186-intel-cm-compiler/intel-cm-compiler-1.0.119-1.fc36.src.rpm

SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03210855-intel-cm-compiler/intel-cm-compiler.spec

SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03210855-intel-cm-compiler/intel-cm-compiler-1.0.119-1.fc36.src.rpm

> %{_includedir}/cm/*

You can take the asterisk off, then RPM will also ensure the package owns the directory and all the content under it.

Review notes:

* Packaging complies with the guidelines
* Package builds and installs
* No serious issues from rpmlint
* Licensing is correct and license files are correctly installed

You can fix the one issue I noticed on import, so...

PACKAGE APPROVED.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/intel-cm-compiler

Built in rawhide: intel-cm-compiler-1.0.119-1.fc36

@ngompa13 you missed a couple of things:

%{_libdir}/libclangFEWrapper.so.*

This allows unnoticed SONAME bumps and is not permitted.

LICENSE.TXT should be in -libs, because it's possible to install -libs separately and it won't include the license text as required.

Also, there's an empty %doc in -devel.

@

One more thing. I'd use rm -rv instead of rm -rf. With the latter, you won't notice if some of the things you're deleting are no longer there, while the former tells you what you deleted.

Thanks!

It should be addressed by intel-cm-compiler-1.0.119-2.fc36 ; as for rm -rf, I'll prefer to leave it as it is. It seems anyway that any upstream update will require poking the package with stick until it starts working, so... :D