Bug 2036115

Summary:	Use function.knative.dev for Knative Functions related labels
Product:	OpenShift Container Platform	Reporter:	OpenShift BugZilla Robot <openshift-bugzilla-robot>
Component:	Dev Console	Assignee:	Aritra Roy <ariroy>
Status:	CLOSED ERRATA	QA Contact:	spathak <spathak>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.10	CC:	abhindas, aos-bugs, ariroy, cjerolim, lball, naisingh, nmukherj, zroubali
Target Milestone:	---
Target Release:	4.9.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-01-31 18:22:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2034170
Bug Blocks:	2048900

Description OpenShift BugZilla Robot 2021-12-29 19:02:24 UTC

+++ This bug was initially created as a clone of Bug #2034170 +++

Description of problem:
Currently Developer Console is using Kubernetes labels "boson.dev/function: true" to determine whether or not the deployed Knative Service is a Function.

We would like to change this label to: "function.knative.dev: true".

The best approach would be to support both type of labels (boson.dev and knative.dev) for some period of time.


Version-Release number of selected component (if applicable):
4.10, 4.9, 4.8

How reproducible:
Always

Steps to Reproduce:
1. Log in to Developer Console on OpenShift with OpenShift Serverless installed.
2. Deploy a function, as per: https://docs.openshift.com/container-platform/4.9/serverless/functions/serverless-functions-getting-started.html
3. The deployed Knative Service is being marked as a function, based on "boson.dev" labels.

Actual results:
"function.knative.dev" labels don't mark the Knative Service as a Function.


Expected results:
Both  "boson.dev/function: true" and "function.knative.dev: true" mark the Knative Service as a Function. 

Additional info:
https://github.com/openshift/console/pull/8233
https://github.com/openshift/console/blob/master/frontend/packages/knative-plugin/src/const.ts#L29
https://github.com/knative-sandbox/kn-plugin-func/pull/717

Comment 2 Christoph Jerolimov 2022-01-24 20:47:22 UTC

Verified on 4.9.0-0.nightly-2022-01-24-193011

Comment 6 errata-xmlrpc 2022-01-31 18:22:33 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.9.18 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:0279