Bug 2034170 - Use function.knative.dev for Knative Functions related labels
Summary: Use function.knative.dev for Knative Functions related labels
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Dev Console
Version: 4.10
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.10.0
Assignee: Aritra Roy
QA Contact: spathak@redhat.com
URL:
Whiteboard:
Depends On:
Blocks: 2036115
TreeView+ depends on / blocked
 
Reported: 2021-12-20 10:12 UTC by Zbyněk Roubalík
Modified: 2022-03-10 16:35 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 2048900 (view as bug list)
Environment:
Last Closed: 2022-03-10 16:35:04 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 10717 0 None open Bug 2034170: add support for new labels for serverless function 2021-12-22 08:34:27 UTC
Red Hat Product Errata RHSA-2022:0056 0 None None None 2022-03-10 16:35:21 UTC

Description Zbyněk Roubalík 2021-12-20 10:12:19 UTC
Description of problem:
Currently Developer Console is using Kubernetes labels "boson.dev/function: true" to determine whether or not the deployed Knative Service is a Function.

We would like to change this label to: "function.knative.dev: true".

The best approach would be to support both type of labels (boson.dev and knative.dev) for some period of time.


Version-Release number of selected component (if applicable):
4.10, 4.9, 4.8

How reproducible:
Always

Steps to Reproduce:
1. Log in to Developer Console on OpenShift with OpenShift Serverless installed.
2. Deploy a function, as per: https://docs.openshift.com/container-platform/4.9/serverless/functions/serverless-functions-getting-started.html
3. The deployed Knative Service is being marked as a function, based on "boson.dev" labels.

Actual results:
"function.knative.dev" labels don't mark the Knative Service as a Function.


Expected results:
Both  "boson.dev/function: true" and "function.knative.dev: true" mark the Knative Service as a Function. 

Additional info:
https://github.com/openshift/console/pull/8233
https://github.com/openshift/console/blob/master/frontend/packages/knative-plugin/src/const.ts#L29
https://github.com/knative-sandbox/kn-plugin-func/pull/717

Comment 2 Christoph Jerolimov 2022-01-04 09:48:39 UTC
Verified on 4.10.0-0.ci-2022-01-04-012641

Comment 4 Aritra Roy 2022-02-01 06:21:38 UTC
Blocks: https://bugzilla.redhat.com/show_bug.cgi?id=2036115

Comment 7 errata-xmlrpc 2022-03-10 16:35:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056


Note You need to log in before you can comment on or make changes to this bug.