Bug 2036115 - Use function.knative.dev for Knative Functions related labels
Summary: Use function.knative.dev for Knative Functions related labels
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Dev Console
Version: 4.10
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.9.z
Assignee: Aritra Roy
QA Contact: spathak@redhat.com
URL:
Whiteboard:
Depends On: 2034170
Blocks: 2048900
TreeView+ depends on / blocked
 
Reported: 2021-12-29 19:02 UTC by OpenShift BugZilla Robot
Modified: 2022-02-01 06:28 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-01-31 18:22:33 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 10755 0 None open [release-4.9] Bug 2036115: add support for new labels for serverless function 2022-01-04 09:49:21 UTC
Red Hat Product Errata RHBA-2022:0279 0 None None None 2022-01-31 18:22:54 UTC

Description OpenShift BugZilla Robot 2021-12-29 19:02:24 UTC
+++ This bug was initially created as a clone of Bug #2034170 +++

Description of problem:
Currently Developer Console is using Kubernetes labels "boson.dev/function: true" to determine whether or not the deployed Knative Service is a Function.

We would like to change this label to: "function.knative.dev: true".

The best approach would be to support both type of labels (boson.dev and knative.dev) for some period of time.


Version-Release number of selected component (if applicable):
4.10, 4.9, 4.8

How reproducible:
Always

Steps to Reproduce:
1. Log in to Developer Console on OpenShift with OpenShift Serverless installed.
2. Deploy a function, as per: https://docs.openshift.com/container-platform/4.9/serverless/functions/serverless-functions-getting-started.html
3. The deployed Knative Service is being marked as a function, based on "boson.dev" labels.

Actual results:
"function.knative.dev" labels don't mark the Knative Service as a Function.


Expected results:
Both  "boson.dev/function: true" and "function.knative.dev: true" mark the Knative Service as a Function. 

Additional info:
https://github.com/openshift/console/pull/8233
https://github.com/openshift/console/blob/master/frontend/packages/knative-plugin/src/const.ts#L29
https://github.com/knative-sandbox/kn-plugin-func/pull/717

Comment 2 Christoph Jerolimov 2022-01-24 20:47:22 UTC
Verified on 4.9.0-0.nightly-2022-01-24-193011

Comment 6 errata-xmlrpc 2022-01-31 18:22:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.9.18 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:0279


Note You need to log in before you can comment on or make changes to this bug.