Bug 2053177
| Summary: | booth: pcs should validate ticket names | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 9 | Reporter: | Tomas Jelinek <tojeline> |
| Component: | pcs | Assignee: | Tomas Jelinek <tojeline> |
| Status: | CLOSED ERRATA | QA Contact: | cluster-qe <cluster-qe> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 9.0 | CC: | cluster-maint, cluster-qe, idevat, mlisik, mmazoure, mpospisi, nwahl, omular, sbradley, svalasti, tojeline |
| Target Milestone: | rc | Keywords: | Triaged |
| Target Release: | 9.1 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | pcs-0.11.2-1.el9 | Doc Type: | Bug Fix |
| Doc Text: |
Cause:
User creates a new booth ticket.
Consequence:
Because pcs doesn't check the ticket's name, it may be unprocessable by booth.
Fix:
Implement ticket name validation in pcs.
Result:
Ticket names which are not processable by booth are not allowed in the configuration. Pcs exits with an error describing the correct format of the name.
|
Story Points: | --- |
| Clone Of: | 1791661 | Environment: | |
| Last Closed: | 2022-11-15 09:48:38 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2027771 | ||
|
Description
Tomas Jelinek
2022-02-10 16:20:58 UTC
*** Bug 2027769 has been marked as a duplicate of this bug. *** Upstream patch + tests: https://github.com/ClusterLabs/pcs/commit/77597efa43af290b4ddfcc3f28770e356d7f233b For a test / reproducer, see comment 0. Implemented checks in this patch: * only alphanumeric characters and "-" are allowed * max name length is 63 characters DevTestResults:
[root@r91-1 ~]# rpm -q pcs
pcs-0.11.2-1.el9.x86_64
[root@r91-1 ~]# rpm -qa booth*
booth-core-1.0-251.2.bfb2f92.git.el9.x86_64
booth-site-1.0-251.2.bfb2f92.git.el9.noarch
booth-1.0-251.2.bfb2f92.git.el9.x86_64
[root@r91-1 ~]# pcs booth setup sites 127.0.0.1 127.0.0.2 127.0.0.3
[root@r91-1 ~]# pcs booth config
authfile = /etc/booth/booth.key
site = 127.0.0.1
site = 127.0.0.2
site = 127.0.0.3
[root@r91-1 ~]# pcs booth ticket add ms_ip_ticket
Error: booth ticket name 'ms_ip_ticket' is not valid, use up to 63 alphanumeric characters or dash
Error: Errors have occurred, therefore pcs is unable to continue
[root@r91-1 ~]# echo $?
1
[root@r91-1 ~]# pcs booth ticket add "$(printf 'a%.0s' {1..64})"
Error: booth ticket name 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' is not valid, use up to 63 alphanumeric characters or dash
Error: Errors have occurred, therefore pcs is unable to continue
[root@r91-1 ~]# echo $?
1
[root@r91-1 ~]# pcs booth ticket add "a-b"
[root@r91-1 ~]# echo $?
0
[root@r91-1 ~]# pcs booth ticket add "$(printf 'b%.0s' {1..63})"
[root@r91-1 ~]# echo $?
0
[root@r91-1 ~]# pcs booth config
authfile = /etc/booth/booth.key
site = 127.0.0.1
site = 127.0.0.2
site = 127.0.0.3
ticket = "a-b"
ticket = "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: pcs security, bug fix, and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2022:7935 |