+++ This bug was initially created as a clone of Bug #1791661 +++ Description of problem: Pcs should check entered ticket names are valid. Valid ticket names: * only alphanumeric characters, "-" and "/" are allowed * max name length is 63 characters * names must be unique (this check may already be present in pcs) pcs commands: * pcs booth ticket add * pcs constraint ticket add Version-Release number of selected component (if applicable): pcs-0.10.4-3.el8 How reproducible: always, easily Steps to Reproduce: 1. pcs booth ticket add ms_ip_ticket 2. booth list Actual results: # pcs booth ticket add ms_ip_ticket # echo $? 0 # booth list Dec 10 16:03:21 virt-154 booth: [22096]: error: ticket name "ms_ip_ticket" invalid; only alphanumeric names. Dec 10 16:03:21 virt-154 booth: [22096]: error: in config file line 5 Dec 10 16:03:21 virt-154 booth: [22096]: error: cannot read config Expected results: Pcs exits with an error explaining why the entered ticket name is not valid. Additional info: reported upstream: https://github.com/ClusterLabs/pcs/issues/229
*** Bug 2027769 has been marked as a duplicate of this bug. ***
Upstream patch + tests: https://github.com/ClusterLabs/pcs/commit/77597efa43af290b4ddfcc3f28770e356d7f233b For a test / reproducer, see comment 0. Implemented checks in this patch: * only alphanumeric characters and "-" are allowed * max name length is 63 characters
DevTestResults: [root@r91-1 ~]# rpm -q pcs pcs-0.11.2-1.el9.x86_64 [root@r91-1 ~]# rpm -qa booth* booth-core-1.0-251.2.bfb2f92.git.el9.x86_64 booth-site-1.0-251.2.bfb2f92.git.el9.noarch booth-1.0-251.2.bfb2f92.git.el9.x86_64 [root@r91-1 ~]# pcs booth setup sites 127.0.0.1 127.0.0.2 127.0.0.3 [root@r91-1 ~]# pcs booth config authfile = /etc/booth/booth.key site = 127.0.0.1 site = 127.0.0.2 site = 127.0.0.3 [root@r91-1 ~]# pcs booth ticket add ms_ip_ticket Error: booth ticket name 'ms_ip_ticket' is not valid, use up to 63 alphanumeric characters or dash Error: Errors have occurred, therefore pcs is unable to continue [root@r91-1 ~]# echo $? 1 [root@r91-1 ~]# pcs booth ticket add "$(printf 'a%.0s' {1..64})" Error: booth ticket name 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' is not valid, use up to 63 alphanumeric characters or dash Error: Errors have occurred, therefore pcs is unable to continue [root@r91-1 ~]# echo $? 1 [root@r91-1 ~]# pcs booth ticket add "a-b" [root@r91-1 ~]# echo $? 0 [root@r91-1 ~]# pcs booth ticket add "$(printf 'b%.0s' {1..63})" [root@r91-1 ~]# echo $? 0 [root@r91-1 ~]# pcs booth config authfile = /etc/booth/booth.key site = 127.0.0.1 site = 127.0.0.2 site = 127.0.0.3 ticket = "a-b" ticket = "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: pcs security, bug fix, and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2022:7935