Description of problem: Pcs should check entered ticket names are valid. Valid ticket names: * only alphanumeric characters, "-" and "/" are allowed * max name length is 63 characters * names must be unique (this check may already be present in pcs) pcs commands: * pcs booth ticket add * pcs constraint ticket add Version-Release number of selected component (if applicable): pcs-0.10.4-3.el8 How reproducible: always, easily Steps to Reproduce: 1. pcs booth ticket add ms_ip_ticket 2. booth list Actual results: # pcs booth ticket add ms_ip_ticket # echo $? 0 # booth list Dec 10 16:03:21 virt-154 booth: [22096]: error: ticket name "ms_ip_ticket" invalid; only alphanumeric names. Dec 10 16:03:21 virt-154 booth: [22096]: error: in config file line 5 Dec 10 16:03:21 virt-154 booth: [22096]: error: cannot read config Expected results: Pcs exits with an error explaining why the entered ticket name is not valid. Additional info: reported upstream: https://github.com/ClusterLabs/pcs/issues/229
After evaluating this issue, there are no plans to address it further or fix it in an upcoming release. Therefore, it is being closed. If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.
*** Bug 2027771 has been marked as a duplicate of this bug. ***
Upstream patch + tests: https://github.com/ClusterLabs/pcs/commit/8f074a7619b33e69f3ff3dfc821cc0239cb85668 For a test / reproducer, see comment 0. Implemented checks in this patch: * only alphanumeric characters and "-" are allowed * max name length is 63 characters
DevTestResults: [root@r8-node-01 ~]# rpm -q pcs pcs-0.10.13-1.el8.x86_64 [root@r8-node-01 ~]# rpm -qa booth* booth-core-1.0-199.1.ac1d34c.git.el8.x86_64 booth-site-1.0-199.1.ac1d34c.git.el8.noarch booth-1.0-199.1.ac1d34c.git.el8.x86_64 [root@r8-node-01 ~]# pcs booth setup sites 127.0.0.{1..3} [root@r8-node-01 ~]# pcs booth config authfile = /etc/booth/booth.key site = 127.0.0.1 site = 127.0.0.2 site = 127.0.0.3 [root@r8-node-01 ~]# pcs booth ticket add ms_ip_ticket Error: booth ticket name 'ms_ip_ticket' is not valid, use up to 63 alphanumeric characters or dash Error: Errors have occurred, therefore pcs is unable to continue [root@r8-node-01 ~]# echo $? 1 [root@r8-node-01 ~]# pcs booth ticket add "$(printf 'a%.0s' {1..64})" Error: booth ticket name 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' is not valid, use up to 63 alphanumeric characters or dash Error: Errors have occurred, therefore pcs is unable to continue [root@r8-node-01 ~]# echo $? 1 [root@r8-node-01 ~]# pcs booth ticket add "a-b" [root@r8-node-01 ~]# echo $? 0 [root@r8-node-01 ~]# pcs booth ticket add "$(printf 'b%.0s' {1..63})" [root@r8-node-01 ~]# echo $? 0 [root@r8-node-01 ~]# pcs booth config authfile = /etc/booth/booth.key site = 127.0.0.1 site = 127.0.0.2 site = 127.0.0.3 ticket = "TicketA" mode = manual ticket = "TicketB" mode = auto ticket = "a-b" ticket = "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: pcs security, bug fix, and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2022:7447