Bug 2074652
| Summary: | Review Request: python-sphinx-theme-builder - Streamline the Sphinx theme development workflow | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jerry James <loganjerry> |
| Component: | Package Review | Assignee: | Dominik 'Rathann' Mierzejewski <dominik> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review |
| Target Milestone: | --- | Flags: | dominik:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-05-07 04:12:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2074647, 2074651 | ||
| Bug Blocks: | |||
|
Description
Jerry James
2022-04-12 17:54:46 UTC
Taking review. Licensing: Most of the code is under MIT license (no headers in files though), but src/sphinx_theme_builder/_internal/passthrough.py is under BSD 3-Clause License, so please mention this in a comment next to the License: field and update it. Source matches upstream: $ sha512sum sphinx-theme-builder-0.2.0a14.tar.gz sphinx-theme-builder-0.2.0a14.tar.gz.orig 15217073a98367f28c5578901f503bc1820ed6b7338f7be773768f6e847c11980f9be6ad9fa8a6adca6edb2ae44ae0f592e05cbc796f2e909efa9bfe979aa5a9 sphinx-theme-builder-0.2.0a14.tar.gz 15217073a98367f28c5578901f503bc1820ed6b7338f7be773768f6e847c11980f9be6ad9fa8a6adca6edb2ae44ae0f592e05cbc796f2e909efa9bfe979aa5a9 sphinx-theme-builder-0.2.0a14.tar.gz.orig Builds fine in mock. Internal testsuite passes. Spec is clean and legible. rpmlint clean. Requires and provides are sane: $ rpm -qpR python3-sphinx-theme-builder-0.2.0-0.1.a14.fc37.noarch.rpm ; echo ; rpm -qp --provides python3-sphinx-theme-builder-0.2.0-0.1.a14.fc37.noarch.rpm /usr/bin/python3 python(abi) = 3.10 python3.10dist(nodeenv) python3.10dist(packaging) python3.10dist(pep621) python3.10dist(rich) python3.10dist(setuptools) python3.10dist(tomli) python-sphinx-theme-builder = 0.2.0-0.1.a14.fc37 python3-sphinx-theme-builder = 0.2.0-0.1.a14.fc37 python3.10-sphinx-theme-builder = 0.2.0-0.1.a14.fc37 python3.10dist(sphinx-theme-builder) = 0.2~a14 python3dist(sphinx-theme-builder) = 0.2~a14 You can fix the minor licensing issue when importing, package approved. Thank you for the review! I will fix the license issue as you described. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sphinx-theme-builder FEDORA-2022-9161e75532 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9161e75532 FEDORA-2022-9161e75532 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-9161e75532` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-9161e75532 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-9161e75532 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. |