Bug 2074647 - Review Request: python-pep621 - PEP 621 metadata parsing
Summary: Review Request: python-pep621 - PEP 621 metadata parsing
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dominik 'Rathann' Mierzejewski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2074652
TreeView+ depends on / blocked
 
Reported: 2022-04-12 17:54 UTC by Jerry James
Modified: 2022-05-07 04:12 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-07 04:12:44 UTC
Type: ---
Embargoed:
dominik: fedora-review+


Attachments (Terms of Use)

Description Jerry James 2022-04-12 17:54:34 UTC
Spec URL: https://jjames.fedorapeople.org/python-pep621/python-pep621.spec
SRPM URL: https://jjames.fedorapeople.org/python-pep621/python-pep621-0.4.0-1.fc37.src.rpm
Fedora Account System Username: jjames
Description: Dataclass for PEP 621 metadata with support for core metadata generation.

This project does not implement the parsing of pyproject.toml containing PEP 621 metadata.  Instead, given a Python data structure representing PEP 621 metadata (already parsed), it will validate this input and generate a PEP 643-compliant metadata file (e.g. PKG-INFO).

Comment 1 Dominik 'Rathann' Mierzejewski 2022-04-12 23:00:36 UTC
Taking review.

Comment 2 Dominik 'Rathann' Mierzejewski 2022-04-13 10:42:17 UTC
Licensing is fine (MIT).
Source matches upstream:
$ sha512sum python-pep621-0.4.0.tar.gz{,.orig}
e48ba90ffd6c6bb548438a6372b614ccc5188e1523a32b876e47b4fd6e9e1eafb94509cb40c4e7dadd03d221c38d67b83fe202a6367b72af1afaa0ac1506bd43  python-pep621-0.4.0.tar.gz
e48ba90ffd6c6bb548438a6372b614ccc5188e1523a32b876e47b4fd6e9e1eafb94509cb40c4e7dadd03d221c38d67b83fe202a6367b72af1afaa0ac1506bd43  python-pep621-0.4.0.tar.gz.orig

Builds fine in mock.
Internal testsuite passes.
Spec is clean and legible.
rpmlint clean. Requires and provides are sane:

$ rpm -qpR python3-pep621-0.4.0-1.fc37.noarch.rpm 
python(abi) = 3.10
python3.10dist(packaging) >= 19
$ rpm -qp --provides python3-pep621-0.4.0-1.fc37.noarch.rpm 
python-pep621 = 0.4.0-1.fc37
python3-pep621 = 0.4.0-1.fc37
python3.10-pep621 = 0.4.0-1.fc37
python3.10dist(pep621) = 0.4
python3dist(pep621) = 0.4

Package approved.

Comment 3 Jerry James 2022-04-14 03:12:31 UTC
Thank you for the review!

Comment 4 Gwyn Ciesla 2022-04-14 13:30:48 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pep621

Comment 5 Fedora Update System 2022-04-20 20:59:38 UTC
FEDORA-2022-9161e75532 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9161e75532

Comment 6 Fedora Update System 2022-04-20 23:05:28 UTC
FEDORA-2022-9161e75532 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-9161e75532`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-9161e75532

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2022-05-07 04:12:44 UTC
FEDORA-2022-9161e75532 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.