Bug 2097799
| Summary: | Review Request: perl-B-Hooks-AtRuntime - Lower blocks from compile time to runtime | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralf Corsepius <rc040203> |
| Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jplesnik, package-review |
| Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-07-14 15:04:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2097759 | ||
| Bug Blocks: | 2097813 | ||
|
Description
Ralf Corsepius
2022-06-16 15:07:47 UTC
Update: Spec URL: https://corsepiu.fedorapeople.org/packages/perl-B-Hooks-AtRuntime.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-B-Hooks-AtRuntime-7-1.fc37.src.rpm Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires
FIX: Use 'perl(:VERSION) >= 5.8.1' instead of 'perl >= 0:5.008001' because
the package has an epoch.
FIX: Please add build-requires:
coreutils - needed for macro %{_fixperms}
findutils - spec file line 47
perl(Carp) - lib/B/Hooks/AtRuntime.pm:8
perl(constant) - lib/B/Hooks/AtRuntime.pm:19
perl(lib) - t/00use.t:5
perl(Exporter) - tlib/t/Util.pm:6
perl(strict) - lib/B/Hooks/AtRuntime.pm:4
perl(warnings) - lib/B/Hooks/AtRuntime.pm:3
perl(XSLoader) - lib/B/Hooks/AtRuntime.pm:6
$ rpm -qp --requires perl-B-Hooks-AtRuntime-7-1.fc37.x86_64.rpm | sort | uniq -c | grep -v rpmlib
1 ld-linux-x86-64.so.2()(64bit)
1 ld-linux-x86-64.so.2(GLIBC_2.3)(64bit)
1 libc.so.6()(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 libc.so.6(GLIBC_2.4)(64bit)
1 perl(Carp)
1 perl(constant)
1 perl(Exporter::Tiny)
1 perl(:MODULE_COMPAT_5.36.0)
1 perl(parent)
1 perl(strict)
1 perl(Sub::Name)
1 perl(warnings)
1 perl(XSLoader)
1 rtld(GNU_HASH)
Binary requires
FIX: Please add run-requires
perl(Filter::Util::Call) - lib/B/Hooks/AtRuntime.pm:25
$ rpm -qp --provides perl-B-Hooks-AtRuntime-7-1.fc37.x86_64.rpm | sort | uniq -c
1 perl(B::Hooks::AtRuntime) = 7
1 perl-B-Hooks-AtRuntime = 7-1.fc37
1 perl-B-Hooks-AtRuntime(x86-64) = 7-1.fc37
Binary provides are Ok.
$ rpmlint ./perl-B-Hooks-AtRuntime*
================================= rpmlint session starts ================================
rpmlint: 2.2.0
configuration:
/usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/licenses.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s =
Rpmlint is ok
TODO: I think 'Build', 'META.json' and the test directory 'tlib' could be
removed from %doc.
Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' item and provide a new spec file.
Resolution:
Not approved
Another update: Spec URL: https://corsepiu.fedorapeople.org/packages/perl-B-Hooks-AtRuntime.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-B-Hooks-AtRuntime-7-2.fc37.src.rpm It looks good. Resolution: Approved (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-B-Hooks-AtRuntime Thanks for the review. |