Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Test-Exports.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Test-Exports-1-1.fc37.src.rpm Description: This module provides simple test functions for testing other modules' import methods. Testing is currently limited to checking which subs have been imported. Fedora Account System Username: corsepiu
Preamble: This is my first Perl package review and I figured reviewing one from a proven packager would be a good opportunity for me to learn some things as well, so thank you and apologies in advance for dumb questions Issues: -The package spec file indicates BSD license, however the source code and package do not appear to include a license file Everything otherwise appears to be in order Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 10 files have unknown license. Detailed output of licensecheck in /home/fuller/fedora-review/2097759-perl- Test-Exports/licensecheck.txt [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/Test(perl-Test-Mock-Guard, perl-MaxMind- DB-Common, perl-Test-Directory, perl-Test-Mojibake, perl-MooseX- Daemonize, perl-Test-Object, perl-Test-Pod-Coverage, perl-Test-Module- Used, perl-Test-Type, perl-Test-Strict, perl-Test-CleanNamespaces, perl-Test-Fake-HTTPD, perl-Test-UseAllModules, perl-Test-Image-GD, perl-Test-Log-Dispatch, perl-Test-Dir, perl-Test-Dist-VersionSync, perl-Test-Fatal, perl-Test-Pod-LinkCheck, perl-Test-Base, perl-Test- CheckDeps, perl-Test-HexDifferences, perl-Test-PostgreSQL, perl-Test- Block, perl-Fennec, perl-Test-LWP-UserAgent, perl-Test-Most, perl- Test-Identity, perl-Test2-Tools-Process, perl-Test-Unit, perl-Test- File-Contents, perl-Test-Time, perl-Test-Version, perl-Test-CPAN-Meta- YAML, perl-Test-Regression, perl-Test-Assert, perl-Test-DiagINC, perl- Test-XML, perl-SQL-Translator, perl-Test-DBICSchemaLoaderDigest, perl- Test-WriteVariants, perl-Test-MemoryGrowth, perl-Test-Net-LDAP, perl- Test-Data-Split, perl-Net-Statsd-Server, perl-Test-Spelling, perl- Test-DistManifest, perl-Test-WWW-Mechanize-CGIApp, perl-Test- FailWarnings, perl-Test-Harness, perl-Test-SubCalls, perl-Test-Class- Most, perl-Test-Filename, perl-Test-HexString, perl-Test-CPAN-Meta, perl-Test-Mock-LWP, perl-Test-YAML-Meta, perl-Test-Portability-Files, perl-Test-Tolerant, perl-Test-Lib, perl-Test-HTTP-Server-Simple- StashWarnings, perl-Test-NeedsDisplay, perl-Test-Run-CmdLine, perl- Test-Unit-Runner-Xml, perl-Test-TempDir, perl-Test-WWW-Selenium, perl- Test-Unit-Lite, perl-Test-HTTP-Server-Simple, perl-Test-RunValgrind, perl-Test-TrailingSpace, perl-Test-Perl-Critic-Policy, perl-Test-TCP, perl-Test-Metrics-Any, perl-Test-NiceDump, perl-Test-Needs, perl-Test- NoTabs, perl-Test-Prereq, perl-Test-Name-FromLine, perl-Test-Perl- Critic-Progressive, perl-Test-Valgrind, perl-Test-Log-Log4perl, perl- Test-SharedFork, perl-Test-Spec, perl-Test-mysqld, perl-Test-Trap, perl-Test-Deep-Fuzzy, perl-Test-LoadAllModules, perl-Test-TypeTiny, perl-Test-YAML-Valid, perl-Test-Vars, perl-Test-Synopsis, perl-Test- Is, perl-CPAN-Changes, perl-Test-Bits, perl-Test-Requires, perl-Test- Manifest, perl-Test-Moose-More, perl-Test-Modern, perl-Test- CheckManifest, perl-Test-CPAN-Meta-JSON, perl-Test-Database, perl- Test-TinyMocker, perl-Test-Regexp-Pattern, perl-Test-Simple, perl- Test-InDistDir, perl-Test-Deep-JSON, perl-Test-Kwalitee, perl-Test- Specio, perl-Test-Command, perl-Test-SQL-Data, perl-Test-Timer, perl- Test-File-ShareDir, perl-Test-Smoke, perl-Test-MockModule, perl-Test- Perl-Critic, perl-Test-WWW-Mechanize, perl-Test-CheckChanges, perl- Test-Distribution, perl-Test-Inter, perl-Test-Git, perl-Test- AutoLoader, perl-Test-Assertions, perl-Test-POE-Client-TCP, perl-Test- Compile, perl-Test-LongString, perl-Test-NoBreakpoints, perl-Test- MockTime, perl-Test-Pod, perl-Perl-Tags, perl-Test-RandomResult, perl- Test-TempDir-Tiny, perl-HTML-Lint, perl-Test-Inline, perl-Test-Regexp, perl-Test-Refcount, perl-Test-Toolbox, perl-Test-Roo, perl-Alien- Build, perl-Test-Able, perl-Test-Exception, perl-Test-Dependencies, perl-Test-MockRandom, perl-Test-RDF-Trine-Store, perl-Test-Requires- Git, perl-Code-TidyAll, perl-Test-JSON, perl-Dist-Zilla, perl-Test- ConsistentVersion, perl-Test-MockObject, perl-Test-Exit, perl-Test- Able-Runner, perl-Test-Run, perl-Test-Carp, perl-Test-EOL, perl-Test- Email, perl-Spellunker, perl-Test-Cmd, perl-Test-Pod-No404s, perl- Test-File, perl-Test-Kwalitee-Extra, perl-Future-AsyncAwait-Test, perl-Test-More-UTF8, perl-Test-Output, perl-Test-POE-Server-TCP, perl- Test-Fixme, perl-Test-Routine, perl-Test-WWW-Mechanize-PSGI, perl- Test-Abortable, perl-Test-LectroTest, perl-Test-Warn, perl-Test- Differences, perl-Test-Number-Delta, perl-Excel-Template-Plus, perl- Test-NoWarnings, perl-Test-utf8, perl-Test-Without-Module, perl-Test- Apocalypse, perl-Test-Stream, perl-Test-API, perl-Test-Harness-Straps, perl-Test-MinimumVersion, perl-Test-Deep-Type, perl-Test-Pod-Content, perl-Test-WWW-Mechanize-Catalyst, perl-Test-Snapshot, perl-Test-Mojo, perl-Test-Command-Simple, perl-Test-Script, perl-Test-Pod-Spelling- CommonMistakes, perl-Test-Memory-Cycle, perl-Test-ClassAPI, perl-Test- NoPlan, perl-Test-HasVersion, perl-Test-Script-Run, perl-Test-Class, perl-Test-Mock-Time, perl-Test-YAML, perl-Test-Reporter, perl-Test- Deep, perl-Test-Warnings, perl-Test-Expect, perl-Test-Signature, perl- Test-RequiresInternet, perl-Test-Some) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Clean - no issues Source checksums ---------------- http://cpan.metacpan.org/authors/id/B/BM/BMORROW/Test-Exports-1.tar.gz : CHECKSUM(SHA256) this package : 01c1ef9a4c159024c10813bf9c43c896fc98d65de79824f875260bd844216857 CHECKSUM(SHA256) upstream package : 01c1ef9a4c159024c10813bf9c43c896fc98d65de79824f875260bd844216857 Requires -------- perl-Test-Exports (rpmlib, GLIBC filtered): perl(:MODULE_COMPAT_5.36.0) perl(B) perl(Test::Builder::Module) perl(parent) perl(strict) perl(warnings) Provides -------- perl-Test-Exports: perl(Test::Exports) perl-Test-Exports Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2097759 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Perl, Generic Disabled plugins: Java, fonts, Haskell, R, Ocaml, PHP, C/C++, Python, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(In reply to Mark E. Fuller from comment #1) > -The package spec file indicates BSD license, however the source code and > package do not appear to include a license file Correct. Not all upstream tarballs contain a detached license file. In this case, the legally binding license can be found near to the end of lib/Test/Exports.pm > Everything otherwise appears to be in order So, will you be able to approve this package?
thanks for the clarification approved
Thank you very much, Mark!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-Exports