Bug 2116077

Summary:	Review Request: rust-hamming - Count ones, fast (aka popcount, hamming weight)
Product:	[Fedora] Fedora	Reporter:	Orion Poplawski <orion>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-08-14 22:32:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2116078

Description Orion Poplawski 2022-08-06 21:49:24 UTC

Spec URL: https://orion.fedorapeople.org/rust-hamming.spec
SRPM URL: https://orion.fedorapeople.org/rust-hamming-0.1.3-1.fc37.src.rpm
Description:

Count ones, fast (aka popcount, hamming weight). This provides a performant
popcount and bitwise hamming distance for a slice of bytes.

Fedora Account System Username: orion

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=90547811

Comment 1 Fabio Valentini 2022-08-11 16:24:53 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Pro tip: Patching Cargo.toml files is such a standard task that rust2rpm provides the "-p" flag to 1) automatically open an editor, 2) generate a patch file, and 3) include the generated patch file in the generated .spec file.

Comment 2 Fabio Valentini 2022-08-11 16:25:54 UTC

Same problem applies here, as well: Make sure you don't accidentally "fedpkg import" the SRPM file, but use the "pristine" spec file, instead.

Comment 3 Orion Poplawski 2022-08-14 22:32:29 UTC

Checked in and built.  Thanks all.