Bug 2116077 - Review Request: rust-hamming - Count ones, fast (aka popcount, hamming weight)
Summary: Review Request: rust-hamming - Count ones, fast (aka popcount, hamming weight)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2116078
TreeView+ depends on / blocked
 
Reported: 2022-08-06 21:49 UTC by Orion Poplawski
Modified: 2022-08-14 22:32 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-08-14 22:32:29 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Orion Poplawski 2022-08-06 21:49:24 UTC
Spec URL: https://orion.fedorapeople.org/rust-hamming.spec
SRPM URL: https://orion.fedorapeople.org/rust-hamming-0.1.3-1.fc37.src.rpm
Description:

Count ones, fast (aka popcount, hamming weight). This provides a performant
popcount and bitwise hamming distance for a slice of bytes.

Fedora Account System Username: orion

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=90547811

Comment 1 Fabio Valentini 2022-08-11 16:24:53 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Pro tip: Patching Cargo.toml files is such a standard task that rust2rpm provides the "-p" flag to 1) automatically open an editor, 2) generate a patch file, and 3) include the generated patch file in the generated .spec file.

Comment 2 Fabio Valentini 2022-08-11 16:25:54 UTC
Same problem applies here, as well: Make sure you don't accidentally "fedpkg import" the SRPM file, but use the "pristine" spec file, instead.

Comment 3 Orion Poplawski 2022-08-14 22:32:29 UTC
Checked in and built.  Thanks all.


Note You need to log in before you can comment on or make changes to this bug.