Bug 2116078
| Summary: | Review Request: rust-primal-bit - Bit-vector specialised to the prime-number-related needs of `primal` | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rust-primal-bit-0.3.1-1.fc38 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-08-30 01:48:33 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2116077 | ||
| Bug Blocks: | 2116079, 2116081 | ||
|
Description
Orion Poplawski
2022-08-06 21:49:42 UTC
Upstream now provides the license files. Spec URL: https://orion.fedorapeople.org/rust-primal-bit.spec SRPM URL: https://orion.fedorapeople.org/rust-primal-bit-0.3.1-1.fc38.src.rpm Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === Reminder: You will need to re-run rust2rpm for every new version of the crate in the future, and for every Cargo.toml patch that touches optional dependencies or features. It appears that you didn't do that between version 0.3.0 and 0.3.1, because the line "# Upstream license specification: MIT/Apache-2.0" is no longer generated for version 0.3.1. Another nit-pick: Remove markdown `markup` from the package's Summary and the bug title. RPM doesn't render markdown anywhere, it's just noise. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-primal-bit Built. Thanks all. |