Bug 2124329
Summary: | Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Kalev Lember <klember> |
Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | decathorpe, package-review |
Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | rust-cssparser-0.28.1-4.fc38 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2022-10-04 10:40:05 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 2124317, 2124326 | ||
Bug Blocks: | 2124365 |
Description
Kalev Lember
2022-09-05 17:39:20 UTC
> The reason for this is that librsvg currently needs 0.28.x
Yeah this is completely fine.
We usually only update library-only crates to incompatible versions when something actually starts to depend on the new version, exactly because it would make no sense to create a compat package and then have the non-compat package be unused.
I'll review this package once the other dependencies are built in rawhide, if that's okay with you.
But if you're in a hurry, I can also do the review with locally built dependencies.
I'm in no hurry at all. Thanks! OK, dependencies are all built in rawhide now. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=91827537 Sorry for the delay. The notification that this is ready got lost in my inbox. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass (only doctests, as test fixtures for unit tests are not included in published crates) - latest (possible) version of the crate is packaged (librsvg2 still requires v0.28.x) - license matches upstream specification ( and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches Meh, I pressed "Submit" too fast. Just skip the post-import tasks that aren't applicable because this is an un-retirement and not a new package :) Awesome, thank you! Releng unretirement request: https://pagure.io/releng/issue/11056 Package unretired and built. |