Bug 2124326 - Review Request: rust-dtoa-short - Serialize float number and truncate to certain precision
Summary: Review Request: rust-dtoa-short - Serialize float number and truncate to cert...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2124329
TreeView+ depends on / blocked
 
Reported: 2022-09-05 17:00 UTC by Kalev Lember
Modified: 2022-09-09 08:28 UTC (History)
2 users (show)

Fixed In Version: rust-dtoa-short-0.3.3-5.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-09-09 08:28:57 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Kalev Lember 2022-09-05 17:00:05 UTC
Spec URL: https://kalev.fedorapeople.org/rust-dtoa-short.spec
SRPM URL: https://kalev.fedorapeople.org/rust-dtoa-short-0.3.3-5.fc38.src.rpm
Description: Serialize float number and truncate to certain precision.
Fedora Account System Username: kalev

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=91668388

This is a re-review of a retired package, one that is needed for building librsvg2. My goal here is to switch librsvg2 to build against Fedora packaged crates instead of the vendored rust crates it's using now.

Comment 1 Fabio Valentini 2022-09-05 21:02:19 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MPL-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

You can proceed with opening the unretirement ticket now.

Comment 2 Kalev Lember 2022-09-06 07:41:46 UTC
Thank you! I've requested unretirement in https://pagure.io/releng/issue/11013

Comment 3 Kalev Lember 2022-09-09 08:28:57 UTC
OK, unretirement is done and package is building in rawhide and I've requested branches for F37.


Note You need to log in before you can comment on or make changes to this bug.