Bug 212692

Summary: New package: libgnomekbd
Product: [Fedora] Fedora Reporter: Matthias Clasen <mclasen>
Component: Package ReviewAssignee: Ray Strode [halfline] <rstrode>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: colding, dcantrell, fedora-package-review, notting
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-11-03 04:38:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 188268    

Description Matthias Clasen 2006-10-28 05:21:19 UTC
The next versions of control-center and a number of other desktop packages will
depend on a new library called libgnomekbd:

http://people.redhat.com/mclasen/review/libgnomekbd-0.1-2.src.rpm
http://people.redhat.com/mclasen/review/libgnomekbd.spec

Comment 1 Bill Nottingham 2006-10-30 16:55:18 UTC
Is this built on top of libxklavier - i.e., gui widgets for keyboard config?

Comment 2 Matthias Clasen 2006-10-30 21:36:45 UTC
It contains interfaces for accessing and storing keyboard configuration,
keyboard drawing interfaces (this is in fact built on top of libxklavier), 
and a keyboard indicator widget (basically the thing you currently see in the
keyboard-indicator applet.

The reason for moving this stuff out into a real library is that people want to 
be able to switch keyboard layouts in the gdm login screen and the screensaver
lock dialog, and proliferation of virtual cvs modules is not the right answer
for that.

Comment 3 Ray Strode [halfline] 2006-11-02 17:33:08 UTC
the description has %{name} in it, that's weird

Comment 4 Ray Strode [halfline] 2006-11-02 17:35:33 UTC
I think we have a policy of putting a full URL in the Source line

Comment 5 Ray Strode [halfline] 2006-11-02 17:41:32 UTC
It says it requires dbus-glib >= 0.34.  Is that really right? isn't it at
version .7something now?

why does this *library* ship a capplet?  What does it do? Can we just nuke it
and not put it in the package?

Also what is the output of rpmlint? any warnings or errors?

Comment 6 Matthias Clasen 2006-11-02 17:53:27 UTC
I don't have a source url, unless you want me to put in the sourceforce download
url. Its not in gnome ftp yet.

Regarding dbus-glib version, I just copied whatever versions the configure
script requires. But if it freaks you out' I'll bump it.

The capplet is for configuring the plugins. I know it is slightly ridiculous,
thats why I have made it NoDisplay. I was not totally sure about leaving it out.
On the one hand, having plugins in a keyboard indicator is nonsense, and we
don't ship any in core anyway, but on the other hand there are many flag lovers
out there who would maybe install the flags plugin if it was packaged in extras.

I guess whoever decides to package the plugins could also package the capplet 
in extras then.

Comment 7 Matthias Clasen 2006-11-02 17:57:20 UTC
Also, aren't reviewers supposed to run rpmlint themselves ? Anyway, it comes up
clean

Comment 8 Ray Strode [halfline] 2006-11-02 18:00:57 UTC
Okay moving to FC-ACCEPT.



Comment 9 Jesse Keating 2006-11-02 19:22:02 UTC
Package added to dist-fc7, please close bug when built for rawhide.

Comment 10 Jules Colding 2006-11-09 11:21:43 UTC
Not sure if this is the right place, but todays yum update gave me:

Transaction Check Error:   file
/etc/gconf/schemas/desktop_gnome_peripherals_keyboard_xkb.schemas from install
of libgnomekbd-2.17.2-1.fc7 conflicts with file from package
control-center-2.17.1-2.fc7

-- 
  jules


Comment 11 Jules Colding 2006-11-09 13:57:19 UTC
OK, it works now.

Thanks,
  jules